Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winePackages.wine: add SDL support #51214

Merged
merged 1 commit into from Dec 7, 2018
Merged

winePackages.wine: add SDL support #51214

merged 1 commit into from Dec 7, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Nov 29, 2018

Motivation for this change

To build the SDL driver for game controllers that has been present but disabled at compile time since wine 3.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (I tested wineWow 3.20 unstable and staging)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build winePackages.stable wine

alyssais
alyssais approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@alyssais alyssais merged commit 0e8e02e into NixOS:master Dec 7, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 8, 2018

Thank you

@rnhmjoj rnhmjoj deleted the wine branch February 23, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @alyssais @GrahamcOfBorg