Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11_legacy340: remove #51220

Closed
wants to merge 1 commit into from
Closed

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 29, 2018

Apparently broken on all kernel versions: #49470 (comment)

@Mic92 Mic92 changed the title nvidia_x11_legacy304: remove nvidia_x11_legacy304/nvidia_x11_legacy340: remove Nov 29, 2018
@Mic92
Copy link
Member Author

Mic92 commented Nov 29, 2018

I just saw @volth @florianjacob in the git history maintaining these packages.
If there are still kernels where these works can we get an upper bound on the kernel version?

@Mic92
Copy link
Member Author

Mic92 commented Nov 29, 2018

@volth I am ok with keeping those version, if they do not show up in nix-review as failed. They should be only whitelisted for kernels where they actually build.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

340 was recently updated in #50841 to prevent build failure with newer kernels
(and backported in #51014)

@florianjacob
Copy link
Contributor

304 was discontinued end of 2017 and won't get updates for newer kernel / X.org versions by nvidia anymore. In theory, it should still work with 4.14, though. @volth can you confirm that? Not sure whether that failed as well in Mic's build failure list.
We could then whitelist it for 4.14 and drop it when NixOS drops 4.14, it will definitely never gain support for newer kernels, and will probably break with a future X.org version as well.

340 will still be updated by nvidia until the end of 2019 to support new kernels and X.org versions. With the recent update & backport, it should work across all kernels again, I have it running here based on 4.19. I'll try to provide the nvidia updates until then.

Source: https://nvidia.custhelp.com/app/answers/detail/a_id/3142

@Mic92
Copy link
Member Author

Mic92 commented Dec 2, 2018

@c0bw3b I tested the build with the compilation fix included. It was broken still.

@Mic92 Mic92 changed the title nvidia_x11_legacy304/nvidia_x11_legacy340: remove nvidia_x11_legacy340: remove Dec 2, 2018
@Mic92
Copy link
Member Author

Mic92 commented Dec 2, 2018

I made a new pull request that marks nvidia 304 as broken on newer kernels.

@Mic92
Copy link
Member Author

Mic92 commented Dec 2, 2018

It seems that just the kernel patch needs an update:

nix log /nix/store/vksc099a01k8843a3idnjf1awlkw38ma-nvidia-x11-340.107-4.19.5.drv copying path '/nix/store/vdmc4m0sf21b73jr3y5fhclbxajmbhg2-nuke-references' from 'https://cache.nixos.org'... unpacking sources tail: error writing 'standard output': Broken pipe Creating directory NVIDIA-Linux-x86_64-340.107 Verifying archive integrity... OK Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 340.107/nix/store/5083hr9iscfzy6yrkldlzp0hbcvgaq84-NVIDIA-Linux-x86_64-340.107.run: line 941: /build/makeself.oGu6IWZC/xz: No such file or directory tail: error writing 'standard output': Broken pipe /nix/store/5083hr9iscfzy6yrkldlzp0hbcvgaq84-NVIDIA-Linux-x86_64-340.107.run: line 932: /dev/tty: No such device or address

/nix/store/kwhrg439922vgph4y0cnpiz07x6f1syp-builder.sh: line 10: 572 Terminated sh $src -x
./libnvidia-cfg.so.340.107
./gl.h
./libnvidia-wfb.so.340.107
./libnvidia-glsi.so.340.107
./nvidia-installer.1.gz
./libnvidia-compiler.so.340.107
./nvidia-persistenced
./nvidia-smi.1.gz
./nvidia-persistenced.1.gz
./nvidia-cuda-mps-control
./nvidia-application-profiles-340.107-key-documentation
./libnvidia-opencl.so.340.107
./nvidia-settings.1.gz
./nvidia-settings
./nvidia_drv.so
./nvidia-bug-report.sh
./nvidia-persistenced-init.tar.bz2
./tls_test
./nvidia-xconfig.1.gz
./nvidia-application-profiles-340.107-rc
./32/
./32/libnvidia-glsi.so.340.107
./32/libnvidia-compiler.so.340.107
./32/libnvidia-opencl.so.340.107
./32/libnvidia-ml.so.340.107
./32/libnvidia-fbc.so.340.107
./32/libvdpau_trace.so.340.107
./32/libnvidia-tls.so.340.107
./32/libnvidia-glcore.so.340.107
./32/libOpenCL.so.1.0.0
./32/tls/
./32/tls/libnvidia-tls.so.340.107
./32/libcuda.so.340.107
./32/libnvcuvid.so.340.107
./32/libGL.so.340.107
./32/libnvidia-eglcore.so.340.107
./32/libnvidia-ifr.so.340.107
./32/libGLESv1_CM.so.340.107
./32/libvdpau.so.340.107
./32/libEGL.so.340.107
./32/libGL.la
./32/libnvidia-encode.so.340.107
./32/libvdpau_nvidia.so.340.107
./32/libGLESv2.so.340.107
./monitoring.conf
./libnvidia-ml.so.340.107
./nvidia-smi
./pkg-history.txt
./libnvidia-fbc.so.340.107
./libvdpau_trace.so.340.107
./nvidia.icd
./libnvidia-tls.so.340.107
./nvidia-xconfig
./libglx.so.340.107
./libnvidia-glcore.so.340.107
./libOpenCL.so.1.0.0
./nvidia-cuda-mps-control.1.gz
./tls/
./tls/libnvidia-tls.so.340.107
./nvidia-debugdump
./tls_test_dso.so
./kernel/
./kernel/nv-frontend.c
./kernel/rmil.h
./kernel/nverror.h
./kernel/os-usermap.c
./kernel/gcc-version-check.c
./kernel/nv-p2p.c
./kernel/nv-pat.c
./kernel/dkms.conf
./kernel/nv-acpi.c
./kernel/os-mlock.c
./kernel/nv-linux.h
./kernel/nv-kernel.o
./kernel/nv-mempool.c
./kernel/nvgputypes.h
./kernel/nv_gpu_ops.h
./kernel/nvidia-modules-common.mk
./kernel/nv-usermap.c
./kernel/nv-cray.c
./kernel/cpuopsys.h
./kernel/xapi-sdk.h
./kernel/nv-memdbg.h
./kernel/nv-misc.h
./kernel/nv-frontend.h
./kernel/nv-dma.c
./kernel/os-interface.h
./kernel/nv-mmap.c
./kernel/nv-vtophys.c
./kernel/os-interface.c
./kernel/nv-proto.h
./kernel/nv-vm.c
./kernel/nv_uvm_interface.h
./kernel/Makefile
./kernel/uvm/
./kernel/uvm/cla06fsubch.h
./kernel/uvm/cla0b5.h
./kernel/uvm/nvidia_uvm_lite_counters.c
./kernel/uvm/uvm-debug.h
./kernel/uvm/nvidia_uvm_lite.c
./kernel/uvm/nvidia_uvm_utils.c
./kernel/uvm/dkms.conf.fragment
./kernel/uvm/nvidia_uvm_common.h
./kernel/uvm/nvidia_uvm_lite.h
./kernel/uvm/uvm_linux_ioctl.h
./kernel/uvm/uvmtypes.h
./kernel/uvm/nvidia_uvm_page_cache.c
./kernel/uvm/nvidia_uvm_common.c
./kernel/uvm/nvkernel.h
./kernel/uvm/uvm.h
./kernel/uvm/nvidia_page_migration.c
./kernel/uvm/cla06f.h
./kernel/uvm/nvidia_uvm_lite_counters.h
./kernel/uvm/nvidia_page_migration.h
./kernel/uvm/uvm_gpu_ops_tests.h
./kernel/uvm/nvidia_uvm_lite_api.c
./kernel/uvm/nvidia_page_migration_kepler.c
./kernel/uvm/nvidia_uvm_linux.h
./kernel/uvm/ctrl2080mc.h
./kernel/uvm/Makefile
./kernel/uvm/nvmisc.h
./kernel/uvm/uvm_ioctl.h
./kernel/uvm/nvidia_page_migration_kepler.h
./kernel/uvm/uvm_gpu_ops_tests.c
./kernel/uvm/nvidia_uvm_utils.h
./kernel/uvm/conftest.sh
./kernel/uvm/nvidia_uvm_lite_events.c
./kernel/uvm/nvidia_uvm_linux.c
./kernel/nv-reg.h
./kernel/nv.h
./kernel/g_nvreadme.h
./kernel/nv-gvi.c
./kernel/os-registry.c
./kernel/os-smp.c
./kernel/os-pci.c
./kernel/conftest.sh
./kernel/nv-pat.h
./kernel/nv-procfs.c
./kernel/nv-p2p.h
./kernel/nv.c
./kernel/nv-i2c.c
./kernel/nv_uvm_interface.c
./kernel/nvtypes.h
./kernel/rmretval.h
./kernel/nv-drm.c
./kernel/nv-chrdev.c
./libcuda.so.340.107
./nvidia-modprobe.1.gz
./libnvcuvid.so.340.107
./nvidia-installer
./libGL.so.340.107
./LICENSE
./makeself-help-script.sh
./html/
./html/commonproblems.html
./html/sdi.html
./html/glxsupport.html
./html/configtwinview.html
./html/profiles.html
./html/acknowledgements.html
./html/minimumrequirements.html
./html/index.html
./html/dpi.html
./html/audiosupport.html
./html/newusertips.html
./html/randr14.html
./html/powermanagement.html
./html/configtvout.html
./html/nvidia-debugdump.html
./html/faq.html
./html/nvidia-persistenced.html
./html/knownissues.html
./html/xrandrextension.html
./html/gpunames.html
./html/installationandconfiguration.html
./html/flippingubb.html
./html/addtlresources.html
./html/i2c.html
./html/optimus.html
./html/procinterface.html
./html/nvidiasettings.html
./html/vdpausupport.html
./html/depth30.html
./html/installdriver.html
./html/supportedchips.html
./html/dma_issues.html
./html/selectdriver.html
./html/nvidia-ml.html
./html/addressingcapabilities.html
./html/displaydevicenames.html
./html/programmingmodes.html
./html/editxconfig.html
./html/installedcomponents.html
./html/introduction.html
./html/framelock.html
./html/xineramaglx.html
./html/configlaptop.html
./html/xcompositeextension.html
./html/configmultxscreens.html
./html/nvidia-smi.html
./html/appendices.html
./html/sli.html
./html/openglenvvariables.html
./html/xconfigoptions.html
./libnvidia-eglcore.so.340.107
./nvidia-modprobe
./libnvidia-ifr.so.340.107
./nvidia-cuda-mps-server
./NVIDIA_Changelog
./nvidia-settings.png
./libGLESv1_CM.so.340.107
./nvidia-settings.desktop
./pci.ids
./README.txt
./libvdpau.so.340.107
./makeself.sh
./libEGL.so.340.107
./glext.h
./libGL.la
./libnvidia-encode.so.340.107
./mkprecompiled
./libvdpau_nvidia.so.340.107
./glx.h
./libGLESv2.so.340.107
./glxext.h
./.manifest
source root is .
setting SOURCE_DATE_EPOCH to timestamp 1527227501 of file ./nvidia-bug-report.sh
patching sources
applying patch /nix/store/i6iv50rgndlpfbfjqd0dlxl98dk1brhl-xf86-video-nvidia-legacy-0010-kernel-4.14.patch
patching file kernel/nv-drm.c
Hunk #1 FAILED at 173.
Hunk #2 FAILED at 183.
2 out of 2 hunks FAILED -- saving rejects to file kernel/nv-drm.c.rej
builder for '/nix/store/vksc099a01k8843a3idnjf1awlkw38ma-nvidia-x11-340.107-4.19.5.drv' failed with exit code 1

@florianjacob
Copy link
Contributor

Fix for the patch failing to be applied to 340.107 with kernel 4.14 kindly provided by @binarin in #51457, by removing it completely.

@Mic92 Mic92 closed this Dec 4, 2018
@Mic92 Mic92 deleted the nvidia-cleanup branch December 4, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants