vimb: 3.1.0 -> 3.3.0 #51232
Merged
vimb: 3.1.0 -> 3.3.0 #51232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 29, 2018
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/fanglingsu/vimb/archive/${version}.tar.gz"; | ||
| sha256 = "1gws028c2v1zh6r142hmjvi2m447lwqqh65m6z3dzcar2yw35z3f"; | ||
| sha256 = "0v3daxs10nndxvcpvx8377aylfdismzkys5n5cs8m89c3fdy6vsw"; |
Mic92
reviewed
Nov 30, 2018
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ makeWrapper gtk2 libsoup webkit gsettings-desktop-schemas ]; | ||
| nativeBuildInputs = [ makeWrapper pkgconfig ]; | ||
| buildInputs = [ gtk3 libsoup webkit gsettings-desktop-schemas ]; |
There was a problem hiding this comment.
I just noticed the makeWrapper:
If you add nativeBuildInputs = [ wrapGAppsHook ]; and buildInputs = [ glib gnome3.gsettings_desktop_schemas ]; then you don't makeWrapper and the result
is less fragile.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/instant-messengers/rambox/default.nix#L33
wrapGAppsHook per reviewer suggestion, ty! :)
dtzWill
force-pushed
the
update/vimb-3.3.0
branch
from
e54564c
to
d57d414
Compare
|
@Mic92 look good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/fanglingsu/vimb/releases/tag/3.2.0
https://github.com/fanglingsu/vimb/releases/tag/3.3.0
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)