Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin cf-private fixes #49880

Merged
merged 10 commits into from Nov 10, 2018
Merged

darwin cf-private fixes #49880

merged 10 commits into from Nov 10, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Nov 7, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
alacritty: add cf-private on darwin
16a54d6 
    note: Undefined symbols for architecture x86_64:
            "_CFURLResourceIsReachable", referenced from:
                alacritty::config::Monitor::new::_$u7b$$u7b$closure$u7d$$u7d$::h8c82fbfba8a3a673 in alacritty-6a8d3226ed5c4bef.alacritty.9tpyu7jw-cgu.1.rcgu.o
            "_NSDefaultRunLoopMode", referenced from:
                alacritty::main::hd6e46019b2208595 in alacritty-6a8d3226ed5c4bef.alacritty.9tpyu7jw-cgu.1.rcgu.o
          ld: symbol(s) not found for architecture x86_64
          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
@LnL7
darwin.trash: add cf-private
ee1c6f6 
    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_NSMutableArray", referenced from:
          objc-class-ref in trash-571f39.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in trash-571f39.o
      "_OBJC_CLASS_$_NSUserDefaults", referenced from:
          objc-class-ref in trash-571f39.o
          objc-class-ref in HGCLIUtils-31f3b3.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
emacs25: add cf-private on darwin and don't propagate frameworks
b378760 
    Undefined symbols for architecture x86_64:
      "_CFNotificationCenterAddObserver", referenced from:
          _macfont_copy_available_families_cache in macfont.o
      "_CFNotificationCenterGetLocalCenter", referenced from:
          _macfont_copy_available_families_cache in macfont.o
      "_NSDefaultRunLoopMode", referenced from:
          _ns_send_appdefined in nsterm.o
          -[EmacsApp run] in nsterm.o
      "_OBJC_CLASS_$_NSArray", referenced from:
          objc-class-ref in nsterm.o
          objc-class-ref in nsmenu.o
          objc-class-ref in nsselect.o
      "_OBJC_CLASS_$_NSData", referenced from:
          objc-class-ref in nsimage.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in nsterm.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in macfont.o
      "_OBJC_CLASS_$_NSLocale", referenced from:
          objc-class-ref in nsterm.o
      "_OBJC_CLASS_$_NSMutableArray", referenced from:
          objc-class-ref in nsterm.o
          objc-class-ref in nsmenu.o
      "_OBJC_CLASS_$_NSMutableDictionary", referenced from:
          objc-class-ref in nsmenu.o
          objc-class-ref in nsselect.o
      "_OBJC_CLASS_$_NSMutableSet", referenced from:
          objc-class-ref in nsterm.o
      "_OBJC_CLASS_$_NSRunLoop", referenced from:
          objc-class-ref in nsmenu.o
      "_OBJC_CLASS_$_NSTimer", referenced from:
          objc-class-ref in nsterm.o
          objc-class-ref in nsmenu.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in nsterm.o
          objc-class-ref in nsfns.o
      "_OBJC_CLASS_$_NSUserDefaults", referenced from:
          objc-class-ref in nsterm.o
          objc-class-ref in nsfns.o
      "_OBJC_EHTYPE_$_NSException", referenced from:
          GCC_except_table8 in nsterm.o
          GCC_except_table1 in nsselect.o
    ld: symbol(s) not found for architecture x86_64
@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 6.topic: emacs labels Nov 7, 2018
@LnL7
emacsMacport: add cf-private
c60816c 
Also remove incorrect emacs25Macport alias.

    Undefined symbols for architecture x86_64:
      "_CFNotificationCenterAddObserver", referenced from:
          _mac_term_init in macterm.o
          _macfont_copy_available_families_cache in macfont.o
      "_CFNotificationCenterGetDistributedCenter", referenced from:
          _mac_term_init in macterm.o
      "_CFNotificationCenterGetLocalCenter", referenced from:
          _macfont_copy_available_families_cache in macfont.o
      "_CFURLCopyResourcePropertyForKey", referenced from:
          _Fmac_file_alias_p in mac.o
      "_CFURLCreateBookmarkDataFromFile", referenced from:
          _Fmac_file_alias_p in mac.o
      "_CFURLCreateByResolvingBookmarkData", referenced from:
          _Fmac_file_alias_p in mac.o
      "_CFURLResourceIsReachable", referenced from:
          _mac_update_title_bar in macfns.o
          _mac_input_source_properties in macfns.o
      "_NSDefaultRunLoopMode", referenced from:
          -[NSApplication(Emacs) runTemporarilyWithBlock:] in macappkit.o
          ___57-[EmacsController handleQueuedNSEventsWithHoldingQuitIn:]_block_invoke in macappkit.o
          _mac_run_loop_run_once in macappkit.o
          ___mac_run_loop_run_once_block_invoke in macappkit.o
          ___37-[EmacsController(Menu) trackMenuBar]_block_invoke in macappkit.o
          ___create_and_show_dialog_block_invoke.2445 in macappkit.o
          ___mac_select_block_invoke in macappkit.o
          ...
      "_NSURLAttributeModificationDateKey", referenced from:
          _mac_document_create_with_url in macappkit.o
      "_OBJC_CLASS_$_NSArray", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSData", referenced from:
          l_OBJC_$_CATEGORY_NSData_$_Emacs in macappkit.o
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSMethodSignature", referenced from:
          l_OBJC_$_CATEGORY_NSMethodSignature_$_Emacs in macappkit.o
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSMutableArray", referenced from:
          l_OBJC_$_CATEGORY_NSMutableArray_$_Emacs in macappkit.o
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSMutableData", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSMutableDictionary", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSMutableSet", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSNull", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSRunLoop", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSSet", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSTimer", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_CLASS_$_NSUserDefaults", referenced from:
          objc-class-ref in macappkit.o
      "_OBJC_EHTYPE_$_NSException", referenced from:
          GCC_except_table81 in macappkit.o
          GCC_except_table810 in macappkit.o
      "_kCFURLIsAliasFileKey", referenced from:
          _Fmac_file_alias_p in mac.o
      "_kCFURLIsSymbolicLinkKey", referenced from:
          _Fmac_file_alias_p in mac.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
fltk: add cf-private on darwin
78623f4 
    Undefined symbols for architecture x86_64:
      "_NSDefaultRunLoopMode", referenced from:
          fl_open_display() in Fl_cocoa.o
          fl_ready() in Fl_cocoa.o
          fl_wait(double) in Fl_cocoa.o
      "_OBJC_CLASS_$_NSArray", referenced from:
          objc-class-ref in Fl_cocoa.o
      "_OBJC_CLASS_$_NSData", referenced from:
          objc-class-ref in Fl_Sys_Menu_Bar.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in Fl_cocoa.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in Fl_cocoa.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in Fl_Native_File_Chooser_MAC.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
glfw: add cf-private on darwin
388a868 
    Undefined symbols for architecture x86_64:
      "_NSDefaultRunLoopMode", referenced from:
          __glfwPlatformPollEvents in cocoa_window.m.o
          __glfwPlatformWaitEvents in cocoa_window.m.o
          __glfwPlatformWaitEventsTimeout in cocoa_window.m.o
      "_OBJC_CLASS_$_NSArray", referenced from:
          objc-class-ref in cocoa_window.m.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in cocoa_window.m.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
keybase: add cf-private on darwin
be9fc0d 
    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_NSData", referenced from:
          objc-class-ref in _x002.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in _x002.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in _x002.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
libui: add cf-private on darwin
0b45d5b 
    Undefined symbols for architecture x86_64:
      "_NSDefaultRunLoopMode", referenced from:
          _uiMainStep in main.m.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in main.m.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in multilineentry.m.o
      "_OBJC_CLASS_$_NSMutableArray", referenced from:
          objc-class-ref in alloc.m.o
          objc-class-ref in box.m.o
          objc-class-ref in menu.m.o
          objc-class-ref in radiobuttons.m.o
          objc-class-ref in tab.m.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
noti: add cf-private on darwin
3310436 
    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in _x002.o
      "_OBJC_CLASS_$_NSRunLoop", referenced from:
          objc-class-ref in _x002.o
    ld: symbol(s) not found for architecture x86_64
@LnL7
opencv: add cf-private on darwin
14e41fe 
    Undefined symbols for architecture x86_64:
      "_NSDefaultRunLoopMode", referenced from:
          _cvWaitKey in window_cocoa.mm.o
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in window_cocoa.mm.o
          objc-class-ref in cap_qtkit.mm.o
      "_OBJC_CLASS_$_NSDictionary", referenced from:
          objc-class-ref in window_cocoa.mm.o
          objc-class-ref in cap_qtkit.mm.o
      "_OBJC_CLASS_$_NSMutableDictionary", referenced from:
          objc-class-ref in window_cocoa.mm.o
      "_OBJC_CLASS_$_NSRunLoop", referenced from:
          objc-class-ref in cap_qtkit.mm.o
      "_OBJC_CLASS_$_NSTimer", referenced from:
          objc-class-ref in cap_qtkit.mm.o
    ld: symbol(s) not found for architecture x86_64
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alacritty, emacs25, fltk, glfw, keybase, libui, noti, opencv

The following builds were skipped because they don't evaluate on x86_64-linux: darwin.trash, emacsMacport

Partial log (click to expand)

patching script interpreter paths in /nix/store/vv6rdp1p0lgza7487ymcjarisiv6snq5-libui-3.1a
checking for references to /build in /nix/store/vv6rdp1p0lgza7487ymcjarisiv6snq5-libui-3.1a...
/nix/store/q812836bwhcyd0535pfn1zxha80b5qbq-alacritty-unstable-0.2.1
/nix/store/hdgnlingc5gan8g3cicj7nh5z0sv6cfy-emacs-25.3
/nix/store/7izivhw2rv6xy1874v2iz5v3ikzf7yxb-fltk-1.3.4
/nix/store/zjjagvh7vf51j9v8rgkas391wlfy5sp7-glfw-3.2.1
/nix/store/hh1hifq24b07gvhynn17cf72rrk55d4w-keybase-2.7.3-bin
/nix/store/vv6rdp1p0lgza7487ymcjarisiv6snq5-libui-3.1a
/nix/store/k56h1dl024cvzmhm47g6m9jyl8ph28nm-noti-3.1.0-bin
/nix/store/fxdm1pllhbhrc7z358ykcx6v7m9gy8cz-opencv-2.4.13

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: emacs25, fltk, glfw, keybase, libui, noti, opencv

The following builds were skipped because they don't evaluate on aarch64-linux: alacritty, darwin.trash, emacsMacport

Partial log (click to expand)

shrinking /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/bin/.ctags-wrapped
shrinking /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/bin/.emacsclient-wrapped
shrinking /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/bin/.ebrowse-wrapped
shrinking /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/bin/.emacs-25.3-wrapped
gzipping man pages under /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/libexec  /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/bin
patching script interpreter paths in /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3
/nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3/libexec/emacs/25.3/aarch64-unknown-linux-gnu/.rcs2log-wrapped: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/jw2sgspf81szigyrkdr81fn5h6vm3ng6-emacs-25.3...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: alacritty, darwin.trash, emacs25, emacsMacport, fltk, glfw, keybase, libui, noti, opencv

Partial log (click to expand)

/nix/store/0h73q9qx1iq6sy8g7hd1vxx2mjnci0sd-apple-framework-Foundation/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:253:9: note: macro 'NS_DEPRECATED' defined here
#define NS_DEPRECATED(_macIntro, _macDep, _iosIntro, _iosDep, ...) CF_DEPRECATED(_macIntro, _macDep, _iosIntro, _iosDep, __VA_ARGS__)
        ^
In file included from /tmp/nix-build-libui-3.1a.drv-0/libui-6ebdc96/darwin/util.m:2:
In file included from /tmp/nix-build-libui-3.1a.drv-0/libui-6ebdc96/darwin/uipriv_darwin.h:4:
In file included from /nix/store/89ghqmf8kph6pn66vj7crkp6ixaqc0y5-apple-framework-Cocoa/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12:
In file included from /nix/store/0h73q9qx1iq6sy8g7hd1vxx2mjnci0sd-apple-framework-Foundation/Library/Frameworks/Foundation.framework/Headers/Foundation.h:74:
In file included from /nix/store/0h73q9qx1iq6sy8g7hd1vxx2mjnci0sd-apple-framework-Foundation/Library/Frameworks/Foundation.framework/Headers/NSURL.h:9:
building of '/nix/store/8z7z5bx8kjxfn016dfa2avpd72qiala3-libui-3.1a.drv' timed out after 3600 seconds
error: build of '/nix/store/8z7z5bx8kjxfn016dfa2avpd72qiala3-libui-3.1a.drv' failed

@LnL7 LnL7 merged commit 8d603be into NixOS:master Nov 10, 2018
@LnL7 LnL7 deleted the darwin-cfprivate-fixes branch November 10, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: emacs 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg