Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liquidsoap: make it find ladspa plugins #49891

Merged
merged 2 commits into from Nov 17, 2018
Merged

liquidsoap: make it find ladspa plugins #49891

merged 2 commits into from Nov 17, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 7, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
liquidsoap: cleanup
3dc63fd 
Moved makeWrapper and pkgconfig to nativeBuildInputs
Refreshed meta.homepage
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2018

@GrahamcOfBorg build liquidsoap

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: liquidsoap

Partial log (click to expand)

make[1]: Leaving directory '/build/liquidsoap-1.3.4-full/liquidsoap-1.3.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4
shrinking /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4/bin/liquidsoap
gzipping man pages under /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4/lib  /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4/bin
patching script interpreter paths in /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4
checking for references to /build in /nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4...
/nix/store/pa5l8527lgmn8fx56a4s2ys49ci0c18d-liquidsoap-full-1.3.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: liquidsoap

Partial log (click to expand)

make[1]: Leaving directory '/build/liquidsoap-1.3.4-full/liquidsoap-1.3.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4
shrinking /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4/bin/liquidsoap
gzipping man pages under /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4/lib  /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4/bin
patching script interpreter paths in /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4
checking for references to /build in /nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4...
/nix/store/9kn8a9f2nd4lchpf7f1bmvgjkp0qfm7j-liquidsoap-full-1.3.4

@c0bw3b c0bw3b merged commit 2d96b9a into NixOS:master Nov 17, 2018
@magnetophon magnetophon deleted the liquidsoap branch June 6, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @c0bw3b @GrahamcOfBorg @markuskowa