Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim wrapper: build with nodejs support #49884

Merged
merged 2 commits into from Nov 15, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 7, 2018

Motivation for this change

I use NeoVim to develop nodejs projects but my editor does not work well because it's missing the NodeJS neovim provider.

I have tested this by running nix-shell -I nixpkgs=. --pure -p 'with import <nixpkgs> {}; neovim.override { withNodeJs=true; }' --run nvim

When I run :checkhealth, I see it reporting nodejs as functional.

## Node.js provider (optional)
  - INFO: Node.js: v8.12.0
  - INFO: Neovim node.js host: /nix/store/fhmp7164mf7pmvin72z3qxiwv6p8ps9p-node-neovim-4.2.1/bin/neovim-node-host
  - OK: Latest "neovim" npm/yarn package is installed: 4.2.1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit changed the title Nixpkgs neovim build with nodejs neovim wrapper: build with nodejs support Nov 7, 2018
@kalbasit
Copy link
Member Author

kalbasit commented Nov 7, 2018

@GrahamcOfBorg build neovim

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim

Partial log (click to expand)

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: which@^1.2.14 (node_modules/which):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/which failed: cache mode is 'only-if-cached' but no cached response available.

up to date in 0.51s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fhmp7164mf7pmvin72z3qxiwv6p8ps9p-node-neovim-4.2.1
patching script interpreter paths in /nix/store/fhmp7164mf7pmvin72z3qxiwv6p8ps9p-node-neovim-4.2.1
checking for references to /build in /nix/store/fhmp7164mf7pmvin72z3qxiwv6p8ps9p-node-neovim-4.2.1...
building '/nix/store/wbj5845nr8klcmn9nkpnvhgvn7bq29hx-neovim-0.3.1.drv'...
/nix/store/8p7plam6zmywj9aqvkb3fp75m6f390d0-neovim-0.3.1

@kalbasit kalbasit force-pushed the nixpkgs_neovim-build-with-nodejs branch from 58c2358 to 54a33ef Compare November 7, 2018 20:49
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim

Partial log (click to expand)

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: which@^1.2.14 (node_modules/which):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/which failed: cache mode is 'only-if-cached' but no cached response available.

up to date in 0.743s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8gyn7p130b0jxrcry3wzcb3s2i7wwfzy-node-neovim-4.2.1
patching script interpreter paths in /nix/store/8gyn7p130b0jxrcry3wzcb3s2i7wwfzy-node-neovim-4.2.1
checking for references to /build in /nix/store/8gyn7p130b0jxrcry3wzcb3s2i7wwfzy-node-neovim-4.2.1...
cannot build derivation '/nix/store/g64vvl12xiji2ph5qdqvadsqnancf5vy-neovim-0.3.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/g64vvl12xiji2ph5qdqvadsqnancf5vy-neovim-0.3.1.drv' failed

@kalbasit
Copy link
Member Author

kalbasit commented Nov 7, 2018

@GrahamcOfBorg build neovim

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: neovim

Partial log (click to expand)

stack traceback:
        [C]: in function 'match'
        /build/source/src/nvim/generators/gen_declarations.lua:255: in main chunk
        [C]: at 0x00405660
make[2]: *** [src/nvim/CMakeFiles/nvim.dir/build.make:253: src/nvim/auto/eval/encode.c.generated.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:2870: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/03aa9ky5bkr7lhiy22yh4di18gjn8wwy-neovim-unwrapped-0.3.1.drv' failed with exit code 2
cannot build derivation '/nix/store/xlwz6czhyymxks1vyh4il8lsdzsjb1p3-neovim-0.3.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xlwz6czhyymxks1vyh4il8lsdzsjb1p3-neovim-0.3.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: neovim

Partial log (click to expand)

copying path '/nix/store/xwshfcsm0g6jg92qv9n86hifcs28wb5g-python3-3.6.6-env' from 'https://cache.nixos.org'...
copying path '/nix/store/zm6hic6ig0cfmf4bh7780q8l91vn269a-python2.7-neovim-0.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/pgah0vvx4ij2hxxm4fg7rphd1bxdvic8-ruby2.5.3-neovim-0.7.0' from 'https://cache.nixos.org'...
copying path '/nix/store/bwb014vlw6ziwlq98pf7qhlr8xhvwa77-python-2.7.15-env' from 'https://cache.nixos.org'...
copying path '/nix/store/hfrfxsqq2j511kkl70ypd3frxjxjjdi6-neovim-ruby-env' from 'https://cache.nixos.org'...
copying path '/nix/store/fn158ydnapyhsrikbdq3b5p8crq9ypp8-unibilium-2.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ks820gxg0xjliihfvjn8rfbl4nzprm56-xsel-unstable-2016-09-02' from 'https://cache.nixos.org'...
copying path '/nix/store/dc9p20jkqq2px0fbh9chha2rnwmvwhsr-neovim-unwrapped-0.3.1' from 'https://cache.nixos.org'...
building '/nix/store/6wcl82vwfb970yrc6z2j7pcfirdvrcg9-neovim-0.3.1.drv'...
/nix/store/8mazyvxk9r3cla2jpm0pryixhr8z4y8f-neovim-0.3.1

@teto
Copy link
Member

teto commented Nov 8, 2018

not familiar with nodeJs but looks fine.

@kalbasit kalbasit force-pushed the nixpkgs_neovim-build-with-nodejs branch from 54a33ef to da4a004 Compare November 15, 2018 03:54
@kalbasit
Copy link
Member Author

I rebased this PR over the latest master, @Mic92 can I get a review on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants