Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 865cbd380d25
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: efe6322ce4cb
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 7, 2018

  1. sage: add fetchSageDiff utility function

    timokau authored and FRidh committed Nov 7, 2018
    Copy the full SHA
    72e6e79 View commit details
  2. pythonPackages.networkx: 2.1 -> 2.2

    timokau authored and FRidh committed Nov 7, 2018
    Copy the full SHA
    efe6322 View commit details
Showing with 31 additions and 3 deletions.
  1. +28 −1 pkgs/applications/science/math/sage/sage-src.nix
  2. +3 −2 pkgs/development/python-modules/networkx/default.nix
29 changes: 28 additions & 1 deletion pkgs/applications/science/math/sage/sage-src.nix
Original file line number Diff line number Diff line change
@@ -39,7 +39,19 @@ stdenv.mkDerivation rec {
./patches/Only-test-py2-py3-optional-tests-when-all-of-sage-is.patch
];

packageUpgradePatches = [
packageUpgradePatches = let
# fetch a diff between base and rev on sage's git server
# used to fetch trac tickets by setting the base to the release and the
# revision to the last commit that should be included
fetchSageDiff = { base, rev, ...}@args: (
fetchpatch ({
url = "https://git.sagemath.org/sage.git/patch?id2=${base}&id=${rev}";
# We don't care about sage's own build system (which builds all its dependencies).
# Exclude build system changes to avoid conflicts.
excludes = [ "build/*" ];
} // builtins.removeAttrs args [ "rev" "base" ])
);
in [
# New glpk version has new warnings, filter those out until upstream sage has found a solution
# https://trac.sagemath.org/ticket/24824
./patches/pari-stackwarn.patch # not actually necessary since tha pari upgrade, but necessary for the glpk patch to apply
@@ -65,6 +77,21 @@ stdenv.mkDerivation rec {
url = "https://git.sagemath.org/sage.git/patch/?id=30cc778d46579bd0c7537ed33e8d7a4f40fd5c31";
sha256 = "13vc2q799dh745sm59xjjabllfj0sfjzcacf8k59kwj04x755d30";
})

# https://trac.sagemath.org/ticket/26326
# needs to be split because there is a merge commit in between
(fetchSageDiff {
name = "networkx-2.2-1.patch";
base = "8.4";
rev = "68f5ad068184745b38ba6716bf967c8c956c52c5";
sha256 = "112b5ywdqgyzgvql2jj5ss8la9i8rgnrzs8vigsfzg4shrcgh9p6";
})
(fetchSageDiff {
name = "networkx-2.2-2.patch";
base = "626485bbe5f33bf143d6dfba4de9c242f757f59b~1";
rev = "db10d327ade93711da735a599a67580524e6f7b4";
sha256 = "09v87id25fa5r9snfn4mv79syhc77jxfawj5aizmdpwdmpgxjk1f";
})
];

patches = nixPatches ++ packageUpgradePatches ++ [
5 changes: 3 additions & 2 deletions pkgs/development/python-modules/networkx/default.nix
Original file line number Diff line number Diff line change
@@ -7,12 +7,13 @@

buildPythonPackage rec {
pname = "networkx";
version = "2.1";
# upgrade may break sage, please test the sage build or ping @timokau on upgrade
version = "2.2";

src = fetchPypi {
inherit pname version;
extension = "zip";
sha256 = "64272ca418972b70a196cb15d9c85a5a6041f09a2f32e0d30c0255f25d458bb1";
sha256 = "12swxb15299v9vqjsq4z8rgh5sdhvpx497xwnhpnb0gynrx6zra5";
};

checkInputs = [ nose ];