Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashplayer: add libglvnd dep #49874

Merged
merged 1 commit into from Nov 7, 2018
Merged

flashplayer: add libglvnd dep #49874

merged 1 commit into from Nov 7, 2018

Conversation

rafaelgg
Copy link
Contributor

@rafaelgg rafaelgg commented Nov 7, 2018

(cherry picked from commit ded5faa)

See: #49873

Motivation for this change

flashplayer-standalone did not start after upgrading to NixOS 18.09 because libGL.so.1 was not on library path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@rafaelgg
flashplayer: add libglvnd dep
e92a041 
(cherry picked from commit ded5faa)
@rafaelgg
Copy link
Contributor Author

rafaelgg commented Nov 7, 2018

cc @timokau

@timokau timokau merged commit bd151c9 into NixOS:release-18.09 Nov 7, 2018
@rafaelgg
Copy link
Contributor Author

rafaelgg commented Nov 7, 2018

Thanks a lot! I have to say the process was both straightforward and seamless. Keep up the great work!

@rafaelgg rafaelgg deleted the release-18.09 branch November 7, 2018 16:47
@timokau
Copy link
Member

timokau commented Nov 7, 2018

You too, nix can always use more contributors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafaelgg @timokau @GrahamcOfBorg