-
-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several improvements in known-bugs file #6963
Conversation
@nielsmh Since you are "only" a contributor, I'm not sure that I can trust you. There are more obsolete known bugs, I think, so this is not as important to remove these 4 right now. A comment from any member about that would be appreciated :) |
Niels literally fixed all those bugs himself... |
If any items are removed from the list, I'd argue it's better to do that in a separate commit either way. One commit to change formatting, one to change contents. |
I think the same as you, so that's why I already have committed them locally and still waiting to push them to remote, because I'd like to know if you are sure you fixed those known bugs, or not, and they just should be fixed. If the 2nd scenario, it would be better to have more listed bugs. |
There are no known bugs or glitches in the new Win32 and DMusic music drivers. I haven't rigorously tested the new Fluidsynth driver, but seeing the code is very simple, any bugs are likely to be in the underlying Fluidsynth library and not OpenTTD's usage of it. I left it playing OpenMSX and other music sets on its own for a good while and didn't notice any oddities. (It's possible to trigger some shutdown-related race conditions causing assertion errors in the Win32 music driver, when running OpenTTD under a debugger and using breakpoints that trigger during shutdown, but I haven't been able to reproduce those with a release build running outside a debugger.) |
Your certainty convinced me :D I just pushed the commit. |
Converted "tabs" to "spaces", changed the order based on the numbering of bugs, made that lines end closer to the 80th character column, changed "Mac OS X" to "macOS", and several other less important changes.
Because FlySpray is no longer the main bug tracking system.
In these commits I did the following: