Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashplayer: add libglvnd dep #49873

Merged
merged 1 commit into from Nov 7, 2018
Merged

flashplayer: add libglvnd dep #49873

merged 1 commit into from Nov 7, 2018

Conversation

rafaelgg
Copy link
Contributor

@rafaelgg rafaelgg commented Nov 7, 2018

Motivation for this change

flashplayer-standalone did not start after upgrading to NixOS 18.09 because libGL.so.1 was not on library path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Nov 7, 2018

Thank you! Since you had the problem on 18.09, you may also want to create a PR to backport this to the last stable release. For that you'd need to cherry-pick -x this commit on top of the release-18.09 branch.

@timokau timokau merged commit 30707eb into NixOS:master Nov 7, 2018
@rafaelgg rafaelgg mentioned this pull request Nov 7, 2018
Merged
9 tasks
@rafaelgg rafaelgg deleted the fix-flashplayer-libglvnd branch November 7, 2018 16:04
@rafaelgg
Copy link
Contributor Author

rafaelgg commented Nov 7, 2018

Will do! Thanks!

@timokau
Copy link
Member

timokau commented Nov 7, 2018

You're welcome and congrats on the contributor label :)

Feel free to ping me in the backport pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rafaelgg @timokau @GrahamcOfBorg @Janik-Haag