Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lollypop-portal: drop #49889

Merged
merged 2 commits into from Nov 9, 2018
Merged

lollypop-portal: drop #49889

merged 2 commits into from Nov 9, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

The functionality of lollypop-portal has been included in lollypop since 0.9.600.

You can simply put any of these tag-editors and kid3-cli in PATH somehow and it'll just work.

I also updated lollypop since they're so frequent.

cc @cocreature since you we're using this

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/bin/lollypop
Wrapping program /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/lib  /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/libexec  /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/bin
patching script interpreter paths in /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611
checking for references to /build in /nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611...
wrapping `/nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/bin/.lollypop-wrapped'...
wrapping `/nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611/bin/.lollypop-cli-wrapped'...
/nix/store/qmcw6d0s0dfhqxrdr5ldg862fhgyfa5s-lollypop-0.9.611

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lollypop

Partial log (click to expand)

Wrapping program /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/bin/lollypop-cli
Wrapping program /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/libexec/lollypop-sp
shrinking RPATHs of ELF executables and libraries in /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/lib  /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/libexec  /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/bin
patching script interpreter paths in /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611
checking for references to /build in /nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611...
wrapping `/nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/bin/.lollypop-cli-wrapped'...
wrapping `/nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611/bin/.lollypop-wrapped'...
/nix/store/qr1cc8hivmxwn83zslbywbibqa9nps57-lollypop-0.9.611

@jtojnar jtojnar merged commit d719a6e into NixOS:master Nov 9, 2018
@worldofpeace worldofpeace deleted the lollypop-drop-portal branch November 9, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @jtojnar