Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dmrconfig module udev rules #49876

Merged
merged 3 commits into from Nov 9, 2018
Merged

Add dmrconfig module udev rules #49876

merged 3 commits into from Nov 9, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 7, 2018

Motivation for this change

Updated dmrconfig, installed the udev rules in the derivation. And created a module to install enable the udev rules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dmrconfig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

installing
install -c -s dmrconfig /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07
shrinking /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin/dmrconfig
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/lib  /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin
patching script interpreter paths in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07
checking for references to /build in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07...
/nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

installing
install -c -s dmrconfig /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07
shrinking /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07/bin/dmrconfig
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07/lib  /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07/bin
patching script interpreter paths in /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07
checking for references to /build in /nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07...
/nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07

@etu etu force-pushed the add-dmrconfig-module-udev-rules branch from d5dec2a to 99875d8 Compare November 8, 2018 07:31
@etu etu force-pushed the add-dmrconfig-module-udev-rules branch from 99875d8 to 7189258 Compare November 8, 2018 07:37
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dmrconfig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

installing
install -c -s dmrconfig /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin/dmrconfig
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07
shrinking /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin/dmrconfig
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/lib  /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07/bin
patching script interpreter paths in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07
checking for references to /build in /nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07...
/nix/store/1132xk64yx5c30i57hjaz1kqm6zwiz41-dmrconfig-2018-11-07

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dmrconfig

Partial log (click to expand)

/nix/store/cgabniyzg6ll5k6frbixkgmgcy6z84xk-dmrconfig-2018-11-07

@adisbladis adisbladis merged commit 8655925 into NixOS:master Nov 9, 2018
@etu etu deleted the add-dmrconfig-module-udev-rules branch November 9, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @adisbladis