Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-agents: init at 1.0.1 #49892

Merged
merged 1 commit into from Nov 23, 2018
Merged

ssh-agents: init at 1.0.1 #49892

merged 1 commit into from Nov 23, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 8, 2018 •
edited

Motivation for this change

I have created this script many years ago, and I finally managed to extract it as a separate project. I'm hoping it'll help someone as frustrated as I was trying to use multiple SSH agents across many terminal sessions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

kalbasit commented Nov 8, 2018

@GrahamcOfBorg build ssh-agents

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0
patching script interpreter paths in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0
/nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0...
/nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0
patching script interpreter paths in /nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0
/nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0...
/nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0
patching script interpreter paths in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0
/nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0...
/nix/store/5na6l4ykwsrvjp6ciladmr64q2jbl9ya-ssh-agents-1.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

/nix/store/n9v04qrkdfak36m9jhljs1bk5jlvm4ar-ssh-agents-1.0.0

@kalbasit kalbasit changed the title ssh-agents: init at 1.0.0 ssh-agents: init at 1.0.1 Nov 8, 2018
@kalbasit kalbasit force-pushed the nixpkgs_add-ssh-agents branch 2 times, most recently from c7e1484 to 665aaaf Compare November 8, 2018 05:00
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1
patching script interpreter paths in /nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1
/nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1...
/nix/store/lg5fnr9rw4f8p98qvk9461xm41sf9xqv-ssh-agents-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1
patching script interpreter paths in /nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1
/nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1...
/nix/store/s27pnpdc4mgwa1h7634f3rbl7h036ici-ssh-agents-1.0.1

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 22, 2018

Not sure about its location under pkgs/applications/misc/
It should rather be under pkgs/tools/networking/ like openssh, lsh, mosh, dropbear, sshpass, ssh-ident, ...

That would also change its position in all-packages.nix -> move up somewhere in the ### TOOLS section

@kalbasit
Copy link
Member Author

kalbasit commented Nov 23, 2018 •
edited

@c0bw3b I moved the package as requested, PTAL.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1
patching script interpreter paths in /nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1
/nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1...
/nix/store/pzlvs0rj0gb8if25jjzm4iky9zj9xrdf-ssh-agents-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ssh-agents

Partial log (click to expand)

Nothing to build, please invoke the install target
installing
install flags: SHELL=/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash PREFIX=\$\(out\) install
install -Dm755 bin/ssh-agents /nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1/bin/ssh-agents
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1
patching script interpreter paths in /nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1
/nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1/bin/ssh-agents: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1...
/nix/store/dnz7wf016jmwxi2q0q2bw2i5xm2mfdj4-ssh-agents-1.0.1

c0bw3b
c0bw3b approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c0bw3b c0bw3b merged commit f11297a into NixOS:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @c0bw3b