Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn: 1.12.1 -> 1.12.3 #49895

Merged
merged 1 commit into from Nov 8, 2018
Merged

yarn: 1.12.1 -> 1.12.3 #49895

merged 1 commit into from Nov 8, 2018

Conversation

screendriver
Copy link
Contributor

@screendriver screendriver commented Nov 8, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

periklis
periklis approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@periklis periklis mentioned this pull request Nov 8, 2018
Closed
@Mic92 Mic92 merged commit 3c4f90c into NixOS:master Nov 8, 2018
@screendriver screendriver deleted the yarn branch November 9, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@screendriver @periklis @Mic92 @GrahamcOfBorg