Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytorch: disable distributed tests #49902

Merged
merged 1 commit into from
Nov 9, 2018
Merged

pytorch: disable distributed tests #49902

merged 1 commit into from
Nov 9, 2018
+1 −1

Conversation

kwohlfahrt
Copy link
Contributor

@kwohlfahrt kwohlfahrt commented Nov 8, 2018 •
edited
Loading

These fail with sandboxing, fixes #48158

Motivation for this change

Pytorch doesn't build with sandboxing enabled (nix build nixpkgs.python3.pkgs.pytorch) without this fix. See the bug report for specific errors.

It would be better to fix the tests, but I can't figure out how at the moment. Will open another PR if I do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@kwohlfahrt
pytorch: disable distributed tests
4d8cf0b 
These fail with sandboxing
@kwohlfahrt kwohlfahrt requested a review from FRidh as a code owner November 8, 2018 12:47
@FRidh
Copy link
Member

FRidh commented Nov 8, 2018

cc maintainer @teh

@teh
Copy link
Contributor

teh commented Nov 8, 2018

Thank you for the fix. I agree disabling tests is not ideal but pytorch is incredibly "unclean" and we're disabling a number of tests already. I.e. good to go @FRidh

@Mic92 Mic92 merged commit 5765be2 into NixOS:master Nov 9, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 9, 2018

Is a backport required?

@kwohlfahrt kwohlfahrt deleted the pytorch branch November 9, 2018 10:09
@andersk
Copy link
Contributor

andersk commented Nov 10, 2018

@Mic92 Yes, and we still need a backport of #46562 as well.

@Mic92
Copy link
Member

Mic92 commented Nov 10, 2018 •
edited
Loading

@andersk does not look trivial because of the openblas upgrade. You can make a pull request targeting staging-18.09 include the changes of this pr and #46562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytorch-0.4.1 fails to build
6 participants
@kwohlfahrt @FRidh @teh @Mic92 @andersk @GrahamcOfBorg