Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gem-config: add iconv #49910

Merged
merged 1 commit into from Nov 8, 2018
Merged

gem-config: add iconv #49910

merged 1 commit into from Nov 8, 2018

Conversation

maljub01
Copy link
Contributor

@maljub01 maljub01 commented Nov 8, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm merged commit 8bfe8c4 into NixOS:master Nov 8, 2018
@zimbatm
Copy link
Member

zimbatm commented Nov 8, 2018

thanks!

@maljub01 maljub01 deleted the iconv-on-darwin branch April 25, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maljub01 @zimbatm @GrahamcOfBorg