Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: remove obsolete aggregate-commands patch #49907

Merged
merged 1 commit into from Nov 8, 2018
Merged

weechat: remove obsolete aggregate-commands patch #49907

merged 1 commit into from Nov 8, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 8, 2018 •
edited

Motivation for this change

This was the rebased version of a patch which landed in WeeChat 2.3
which is now used on nixpkgs master (see 2702772).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
weechat: remove obsolete aggregate-commands patch
5d9add4 
This was the rebased version of a patch which landed in WeeChat 2.3
which is now used on nixpkgs master (see 2702772).
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/8mk7xlwbdp9lfnapcvhc9z1sgqxqi2p6-weechat-2.3-lua' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/x8w743fld7pzqgnk3hkwj0y0j413lrsv-weechat-2.3-perl' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/f3r4z9w7vyyv5041n6gj8h1b0iq0nrgc-weechat-2.3-python' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/wp3mab1ng2pkbzq53kxz6bwxkgb89f8q-weechat-2.3-ruby' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/krb11sfxii7xii8swb82097z5wxjms6m-weechat-2.3-tcl' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/5irnnmy7vn7iycmbkaanblcljs62fxfq-weechat-plugins' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/fvvadkfyw4kgh43ygzvmnd08v26qa5cy-weechat' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/85qksig5z1l8435fy5p0zmcgsjxwmqcb-weechat-headless' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/24z581hf6xnkm5casmj88yn0xalvl4hz-weechat-bin-env-2.3' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/24z581hf6xnkm5casmj88yn0xalvl4hz-weechat-bin-env-2.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/kbnkfsik4sfbjvzdbspavs57bz0dd4rb-weechat-2.3-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/1a9i8nz5jp7id8398d4xyczzpv7fd1qd-guile-2.0.13' from 'https://cache.nixos.org'...
copying path '/nix/store/bkn4bhmdm8mqxdm8haqnp1pq3pfcjshp-weechat-2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/mxhgnlhmq3m9akgrxmjjpx2b741024a3-weechat-2.3-guile' from 'https://cache.nixos.org'...
copying path '/nix/store/c9gx46zsfa9g5iixghy24kb63jxsi8d0-weechat-2.3-ruby' from 'https://cache.nixos.org'...
copying path '/nix/store/rq3vfjl55f4arks2099wdlmdjh3fyaw9-weechat-plugins' from 'https://cache.nixos.org'...
copying path '/nix/store/k5yyqkc1rk9xwgkj7zfzxkvwpbq1093p-weechat' from 'https://cache.nixos.org'...
copying path '/nix/store/27h35sh39xnhbjk4hq7j419xnzykmcph-weechat-headless' from 'https://cache.nixos.org'...
copying path '/nix/store/dq25xbgqfddw07i9d6kxdmv0cgkikcp1-weechat-bin-env-2.3' from 'https://cache.nixos.org'...
/nix/store/dq25xbgqfddw07i9d6kxdmv0cgkikcp1-weechat-bin-env-2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: weechat

Partial log (click to expand)

copying path '/nix/store/afis92vapvbqm0mbybbw9nd0pp03f12m-guile-2.0.13' from 'https://cache.nixos.org'...
copying path '/nix/store/9znkmz9z4ghf8i5wzr23i0ic4nm7qaqi-weechat-2.3-lua' from 'https://cache.nixos.org'...
copying path '/nix/store/ykg7wqph1mzjp1pb3wf8wv2i5rzm3ngv-weechat-2.3' from 'https://cache.nixos.org'...
copying path '/nix/store/vmr98lc27w29smx4abwasbjmqcrg9d14-weechat-2.3-tcl' from 'https://cache.nixos.org'...
copying path '/nix/store/vbsmhg996n1di2iy733l8mdn6h4897zn-weechat-2.3-guile' from 'https://cache.nixos.org'...
copying path '/nix/store/y13543vbpyd54qm8gzsm5z0ndrv3x2m0-weechat-plugins' from 'https://cache.nixos.org'...
copying path '/nix/store/07038zvwb3vn4i3v0v60djh294x0hm39-weechat' from 'https://cache.nixos.org'...
copying path '/nix/store/gcb7f4j2khz4n4ycb7jzalavbx4ps1n2-weechat-headless' from 'https://cache.nixos.org'...
copying path '/nix/store/n1acfjjmry9mqh7mw3wgs3xsmnnr6v42-weechat-bin-env-2.3' from 'https://cache.nixos.org'...
/nix/store/n1acfjjmry9mqh7mw3wgs3xsmnnr6v42-weechat-bin-env-2.3

@Ma27
Copy link
Member Author

Ma27 commented Nov 8, 2018

No rebuild needed (obviously) and no unexpected fallout according to borg, so this should be safe to merge :)

@Ma27 Ma27 merged commit 57cb766 into NixOS:master Nov 8, 2018
@Ma27 Ma27 deleted the remove-obsolete-weechat-patch branch November 8, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @GrahamcOfBorg