Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bash: set title in PS1 #51678

Merged
merged 1 commit into from Dec 8, 2018
Merged

nixos/bash: set title in PS1 #51678

merged 1 commit into from Dec 8, 2018

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 7, 2018 •
edited

Motivation for this change

Before:

before

After:

after

This is the default behavior on Debian. It helps to differentiate between different NixOS systems (when some windows run SSH) and between different local paths, while also properly integrating with Vim's set title.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 7, 2018

LGTM!

@lukateras lukateras merged commit 5c685fe into master Dec 8, 2018
@lukateras lukateras deleted the yegortimoshenko-patch-1 branch December 8, 2018 18:35
hedning added a commit to hedning/nixpkgs that referenced this pull request Dec 9, 2018
@hedning
nixos/tests/i3wm: fix terminal title
373be82 
Probably due to NixOS#51678 which makes bash set the terminal title.
@hedning hedning mentioned this pull request Dec 9, 2018
Merged
10 tasks
@tadfisher
Copy link
Contributor

This broke my Emacs prompt, btw.

@tadfisher
Copy link
Contributor

Example:

[0;tad@curie: ~/src/pass-otptad@curie:~/src/pass-otp]$

@tadfisher tadfisher mentioned this pull request Dec 17, 2018
Merged
10 tasks
Mic92
Mic92 reviewed Dec 18, 2018
View reviewed changes
nixos/modules/programs/bash/bash.nix
@@ -98,7 +98,7 @@ in
if [ "$TERM" != "dumb" -o -n "$INSIDE_EMACS" ]; then
PROMPT_COLOR="1;31m"
let $UID && PROMPT_COLOR="1;32m"
PS1="\n\[\033[$PROMPT_COLOR\][\u@\h:\w]\\$\[\033[0m\] "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before there were two \\ before the dollar sign. Was this indented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lukateras @grahamc @tadfisher @Mic92 @Ma27 @GrahamcOfBorg