Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldc: 1.11.0 -> 1.12.0 #51720

Closed
wants to merge 1 commit into from
Closed

ldc: 1.11.0 -> 1.12.0 #51720

wants to merge 1 commit into from

Conversation

lionello
Copy link
Contributor

@lionello lionello commented Dec 8, 2018

Motivation for this change

Update to latest official release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lionello
Copy link
Contributor Author

lionello commented Dec 8, 2018

@ThomasMader Need your comment on those commented lines, what's their purpose?

https://github.com/NixOS/nixpkgs/pull/51720/files#diff-a9931c506e99f6acd6420fb8c119b55cR41

Build using llvm_6 to match official release.
@ThomasMader
Copy link
Contributor

First of all, thanks for your interest in D and ldc.

This entire optional String block removed the variadic.d test case in the dmd testsuite for the bootstrap version of ldc.
Maybe it's not needed anymore because something was fixed in ldc 0.17.6. You could try to reproduce the problem on your machine by switching back to 0.17.5 without removing the variadic.d testcase.
In case this doesn't make any problems anymore, this entire optional block can be removed.
The comment above was just to show the error message that occurred.

There are some "Can be removed" or "TODO" comments around which should be fixable now with this new version too. Please remove those fixes too as they were fixed upstream.

@ThomasMader
Copy link
Contributor

I just realized that the testing/check phase is disabled for the bootstrap version at the moment.
I introduced it with f4f488d#diff-a9931c506e99f6acd6420fb8c119b55cR161
I did it because I figured that checking the bootstrapping version has not much of a value and is just prolonging the build time. It should be enough of a test If it builds ldc correctly and all tests are successful there.
I should have removed the code for it with that commit.

In that case you can just leave your patch as is or make the changes, I leave it up to you. If you don't want to make the cleanup I will do it afterwards.
Let me know when you are ready for merging, I will trigger a GrahamcOfBorg build for testing.

@ThomasMader ThomasMader mentioned this pull request Dec 27, 2018
10 tasks
@xeji
Copy link
Contributor

xeji commented Jan 1, 2019

closing in favor of #52964

@xeji xeji closed this Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants