Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metamath: init at 0.167 #51764

Merged
merged 1 commit into from Dec 9, 2018
Merged

Metamath: init at 0.167 #51764

merged 1 commit into from Dec 9, 2018

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Dec 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Taneb
Copy link
Contributor Author

Taneb commented Dec 8, 2018

This points to my own repository because there is no official repository for metamath, there's a download location but it gets updated in place with no permanent link. See discussion at https://groups.google.com/forum/#!topic/metamath/N4WEWQQVUfY

@rasendubi
Copy link
Member

Could you also squash commits? (Add Taneb as maintainer doesn't look like a good commit name in isolation.)

@GrahamcOfBorg build metamath

@Taneb
Copy link
Contributor Author

Taneb commented Dec 9, 2018

Thanks for the feedback! I've made the suggested changes and squashed

@rasendubi
Copy link
Member

@GrahamcOfBorg build metamath

@rasendubi rasendubi merged commit 2801679 into NixOS:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @rasendubi @GrahamcOfBorg