Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: fix link to poppler patch #51730

Merged
merged 1 commit into from Dec 8, 2018
Merged

texlive: fix link to poppler patch #51730

merged 1 commit into from Dec 8, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 8, 2018

Motivation for this change

Recently Archlinux removed that patch, adding ?id gives us a stable url

It has the same hash

$ nix-prefetch-url --name test.patch 'https://git.archlinux.org/svntogit/packages.git/plain/trunk/texlive-poppler-0.64.patch?h=packages/texlive-bin&id=da56abf0f8a1e85daca0ec0f031b8fa268519e6'
path is '/nix/store/aqdp6nla643jb6niyprmkdhbl5rc2c1v-test.patch'
0443d074zl3c5raba8jyhavish706arjcd80ibb84zwnwck4ai0w

fixes #51722

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 8, 2018

@GrahamcOfBorg build texlive.combined.scheme-small

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 8, 2018

Verified locally too, patch is fetched and hash is good

@c0bw3b c0bw3b merged commit 4107c3d into NixOS:master Dec 8, 2018
@marsam marsam deleted the texlive-fix-poppler-patch-link branch December 8, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to texlive-poppler-0.64.patch is broken
3 participants
@marsam @c0bw3b @GrahamcOfBorg