Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displaylink: changed systemd start to not block #51760

Merged
merged 3 commits into from Dec 9, 2018
Merged

displaylink: changed systemd start to not block #51760

merged 3 commits into from Dec 9, 2018

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Dec 8, 2018

Previously during boot, displaylink would hang during boot for the 2 minutes timeout.
This fixes issue #51684

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb
displaylink: changed systemd start to not block
c72bb28 
Previously during boot, displaylink would hang during boot for the 2
minutes timeout.
@eyJhb
Copy link
Member Author

eyJhb commented Dec 8, 2018 via email •
edited

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2018 •
edited

I mean one could build a patch that places PATH=@systemd@/bin:$PATH on the second line and the replaces the systemctl command that is also in the same file.
The patch itself would be then substituted with substituteAll to replace @systemd@ with the actual systemd reference.

@Mic92 Mic92 merged commit f0f3673 into NixOS:master Dec 9, 2018
eyJhb added a commit to eyJhb/nixpkgs that referenced this pull request Dec 11, 2018
@eyJhb
displaylink: changed systemd start to not block (NixOS#51760)
4ba8f94 
Previously during boot, displaylink would hang during boot for the 2
minutes timeout.

(cherry picked from commit f0f3673)
@eyJhb eyJhb mentioned this pull request Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @Mic92 @GrahamcOfBorg