Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intelmetool: init at 4.8.1 #51679

Merged
merged 1 commit into from Dec 13, 2018
Merged

intelmetool: init at 4.8.1 #51679

merged 1 commit into from Dec 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb
srhb requested changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether it would make sense to reuse the src and version from nvramtool, but I guess there's not much precedent for that. The duplication just seems a little off to me, but probably no biggie.

pkgs/tools/misc/intelmetool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/intelmetool/default.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Dec 12, 2018

@GrahamcOfBorg build intelmetool

@ghost
Copy link
Author

ghost commented Dec 13, 2018

@srhb Also cbfstool uses the same repo. Should be tested after version bump though. What would be correct way to share src and version between them? Is there any example in nixpkgs?

@srhb
Copy link
Contributor

srhb commented Dec 13, 2018

@gnidorah I haven't found any, so at least it's not prevalent :/

@srhb
Copy link
Contributor

srhb commented Dec 13, 2018

@GrahamcOfBorg build intelmetool

@srhb srhb merged commit d770355 into NixOS:master Dec 13, 2018
@ghost
Copy link
Author

ghost commented Dec 13, 2018

@srhb Thanks!

@ghost ghost deleted the intelmetool branch December 13, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @GrahamcOfBorg