gawkextlib: init at unstable #51721
Merged
gawkextlib: init at unstable #51721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomberek
force-pushed
the
gawkextlib-init
branch
2 times, most recently
from
a29f4b1
to
9b83ad5
Compare
veprbl
reviewed
Dec 26, 2018
|
@veprbl Thanks for the review. Updated PR taking your suggestions. There are a few I don't have a solid answer for at the moment. |
|
Are there any updates on this pull request, please? |
|
Not right now. I’m willing to make some changes if there is interest. |
tomberek
requested review from
adisbladis,
alyssais,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
joachifm,
matthewbauer,
nbp,
peti,
Profpatsch,
rycee,
thoughtpolice,
ttuegel and
WilliButz
as code owners
tomberek
force-pushed
the
gawkextlib-init
branch
from
60a4aea
to
a75fbf2
Compare
|
Woops. Did a massive merge by mistake. Force-pushed a more reasonable change set. |
|
Anything else needed? |
Fixes build error (on darwin?)
In file included from xml_puller.c:18:
./xml_puller.h:17:10: fatal error: 'iconv.h' file not found
^~~~~~~~~
1 error generated.
|
@tomberek I made some changes, could you review? |
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
|
Builds and functions as expected |
|
@GrahamcOfBorg build gawkextlib gawk-with-extensions |
veprbl
approved these changes
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Using AWK recently. Found some extensions that are useful for JSON, etc.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)