Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.robotframework-selenium2library: 1.6.0 -> 3.0.0 #51731

Merged
merged 5 commits into from Dec 11, 2018
Merged

pythonPackages.robotframework-selenium2library: 1.6.0 -> 3.0.0 #51731

merged 5 commits into from Dec 11, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 8, 2018

Motivation for this change

Fixes #51727

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 8, 2018 14:37
@marsam
Copy link
Contributor Author

marsam commented Dec 8, 2018 •
edited

fyi, since is a major version upgrade, I've checked with nix-review locally and it didn't throw any error

das-g
das-g reviewed Dec 8, 2018
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a different sourcecode location be fetched, if it provides tests?

pkgs/development/python-modules/robotframework-selenium2library/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/robotframework-seleniumlibrary/default.nix Show resolved Hide resolved
@marsam marsam force-pushed the update-python-robotframework-selenium2library branch from b5d2672 to ffa3e27 Compare December 8, 2018 20:12
@marsam
Copy link
Contributor Author

marsam commented Dec 8, 2018

@worldofpeace, @das-g thanks for your review. I've updated the PR with your suggestions.
I've tested on darwin and linux, both on python2 and python3.

@marsam marsam force-pushed the update-python-robotframework-selenium2library branch from ffa3e27 to b7201f6 Compare December 9, 2018 00:55
das-g
das-g suggested changes Dec 9, 2018
View reviewed changes
pkgs/development/python-modules/robotframework-seleniumlibrary/default.nix
};

propagatedBuildInputs = [ robotframework selenium ];
checkInputs = [ mockito robotstatuschecker approvaltests ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would testing robotframework-seleniumlibrary with approvaltests start an interactive diff/merge tool (whether graphical or CLI), when the respective tests fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will depend whether if the approval reporter is available (e.g. non-sandboxed builds), otherwise it will just throw an ApprovalException exception

pkgs/development/python-modules/mockito/default.nix
'';

meta = with stdenv.lib; {
description = "Spying framework";
Copy link
Member

@das-g das-g Dec 9, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the README of the mockito-python indeed calls it a "spying framework", I think that label is somewhat confusing out of context. It's only for "spying" on the system-under-test, specifically how that uses the provided mocks, partial mocks and stubs. It's not for spying on, say, people or organizations.

Thus I'd go with how the Java library of the same name calls itself: A "mocking framework".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally inclined to use the description used by the project itself, but I can change it if you prefer it

pkgs/development/python-modules/robotframework-selenium2library/default.nix

propagatedBuildInputs = [ robotframework selenium docutils decorator ];
propagatedBuildInputs = [ robotframework-seleniumlibrary ];

meta = with stdenv.lib; {
description = "Web testing library for Robot Framework";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the description indicate, that this is for helping transitioning and that the new name is robotframework-seleniumlibrary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I think adding a to the project homepage should be enough; but if you prefer it I can add it to longDescription

pkgs/development/python-modules/robotframework-selenium2library/default.nix

meta = with stdenv.lib; {
description = "Web testing library for Robot Framework";
homepage = http://robotframework.org/;
homepage = https://github.com/robotframework/Selenium2Library;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkgs/development/python-modules/robotstatuschecker/default.nix Outdated Show resolved Hide resolved
@marsam marsam force-pushed the update-python-robotframework-selenium2library branch from b7201f6 to 93805bb Compare December 10, 2018 02:04
dotlambda
dotlambda requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new packages are missing meta.maintainers.

@marsam marsam force-pushed the update-python-robotframework-selenium2library branch from 93805bb to cf46e28 Compare December 11, 2018 14:10
@marsam
Copy link
Contributor Author

marsam commented Dec 11, 2018

Fixed, I added myself as maintainer

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.approvaltests python3.pkgs.approvaltests

worldofpeace
worldofpeace approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nix-review with success

@dotlambda
Copy link
Member

I was interested in Darwin specifically and as everything seems to work there, I think this is good to go!

@dotlambda dotlambda merged commit 3c71836 into NixOS:master Dec 11, 2018
@worldofpeace
Copy link
Contributor

@marsam Many thanks again 🎆

@marsam marsam deleted the update-python-robotframework-selenium2library branch December 11, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g requested changes

@dotlambda dotlambda dotlambda requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @dotlambda @worldofpeace @das-g @GrahamcOfBorg