shiboken: add support for Python 3.7 #51732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@flokli requested in #51634 to have a look on shiboken. I was still using Python 3.6 and it was working, so I had a look and noticed that shiboken was patched for Python 3.5 and 3.6. This PR extends the same patch use for 3.7, as well.
I have not run nix-review (I must start doing so), but I have built and run successfully the
spyder
application that @flokli mentioned on the previous PR. (P.S.: spyder could get updated to a newer version, but hopefully someone else can take it from here.)Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)