Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghostscript: 9.25 -> 9.26 #51746

Merged
merged 1 commit into from Dec 9, 2018
Merged

ghostscript: 9.25 -> 9.26 #51746

merged 1 commit into from Dec 9, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 8, 2018

Motivation for this change

Fixes a vulnerability: #51739

cc @flokli

Should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rasendubi
Copy link
Member

This causes mass rebuild so should probably lend to staging branch first. On the other hand, it's a critical security issue, so I am not sure.

@grahamc @fpletz @domenkozar what's our policy for security-related patches that cause mass rebuilds?

@rasendubi rasendubi added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 8, 2018
@orivej
Copy link
Contributor

orivej commented Dec 8, 2018

In general, under 500 rebuilds per platform is not a mass rebuild. ghostscript can go to master.
All mass rebuilds go to staging, and security-related should be picked to staging-next rather sooner than later.

@flokli flokli merged commit 1b30dc8 into NixOS:master Dec 9, 2018
@flokli flokli mentioned this pull request Dec 9, 2018
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@hedning hedning deleted the ghostscript-9.26 branch October 15, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants