geckodriver: unstable-2018-02-24 -> 0.22.0 #51725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As #51727 (comment) stated that robotframework-selenium2library is Python 2 only, I tried diff --git a/pkgs/development/python-modules/robotframework-selenium2library/default.nix b/pkgs/development/python-modules/robotframework-selenium2library/default.nix
index 15fd977936b..1bcbd85f147 100644
--- a/pkgs/development/python-modules/robotframework-selenium2library/default.nix
+++ b/pkgs/development/python-modules/robotframework-selenium2library/default.nix
@@ -5,12 +5,15 @@
, selenium
, docutils
, decorator
+, isPy3k
}:
buildPythonPackage rec {
version = "1.6.0";
pname = "robotframework-selenium2library";
+ disabled = isPy3k;
+
src = fetchPypi {
inherit pname version;
sha256 = "1asdwrpb4s7q08bx641yrh3yicgba14n3hxmsqs58mqf86ignwly";
However, that still failed (though without any useful error message): |
|
@GrahamcOfBorg build geckodriver |
|
Fails to build on Darwin.
Needs a dependency on |
das-g
force-pushed
the
geckodriver-0.22.0
branch
3 times, most recently
from
8e37721
to
8696486
Compare
alyssais
reviewed
Dec 10, 2018
Motivation: unstable-2018-02-24 (which reports to be 0.19.1, but probably doesn't correspond to any actual geckodriver release) isn't compatible with the currently shipped Firefox version 63.0 closes NixOS#50380
das-g
force-pushed
the
geckodriver-0.22.0
branch
from
8696486
to
1edf950
Compare
|
@GrahamcOfBorg build geckodriver |
alyssais
added
the
9.needs: port to stable
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50380
Motivation for this change
geckodriver unstable-2018-02-24 (which reports to be 0.19.1, but probably doesn't correspond to any actual geckodriver release) isn't compatible with the currently shipped Firefox version 63.0.
geckodriver ≥ 0.21 is needed to be compatible with Firefox > 62 according to the documentation. The latest version seems to be geckodriver 0.23.0, but the released source for that is missing the
Cargo.lockfile (see #50380 (comment), mozilla/geckodriver#1427, mozilla/geckodriver#1403), thus I've packaged 0.22.0 for now.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"python37Packages.robotframework-selenium2libraryalso present inmasterandnixos-18.09(reported as Python SyntaxError when building python37Packages.robotframework-selenium2library #51727)details
nix-shell -p nox --run "nox-review wip"rannix-build -A python37Packages.selenium -A bepasty -A geckodriver -A python27Packages.bokeh -A python27Packages.selenium -A python37Packages.robotframework-selenium2library -A python27Packages.robotframework-selenium2library -A python37Packages.splinter -A python37Packages.bokeh -A searx -A python27Packages.splinter $PATH_TO_LOCAL_nixpkgs_CLONE, which failed withBecause I noticed that
masterwithout my change (c37ae1d) is affected too, I triednix-shell -p nox --run "nox-review --keep-going wip"to see if the rest builds fine, but that failed witha
TypeErrorin nox./result/bin/)nix path-info -Sbefore and after)