Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net_snmp: 5.7.3 -> 5.8 #51683

Closed
wants to merge 2 commits into from
Closed

net_snmp: 5.7.3 -> 5.8 #51683

wants to merge 2 commits into from

Conversation

cyounkins
Copy link
Contributor

Motivation for this change

Fixes #51459 #48099

Wasn't able to get the perl modules working, but I may revisit it after this is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyounkins
Copy link
Contributor Author

@wkennington Could you review?

@cyounkins
Copy link
Contributor Author

@peterhoeg could you review/test?

@matthewbauer
Copy link
Member

@GrahamcOfBorg build net_snmp

@cyounkins
Copy link
Contributor Author

Good to go?

@peterhoeg
Copy link
Member

@cyounkins, really appreciate the PR but haven't had the time to take a look.

@peterhoeg
Copy link
Member

Cc @volth as resident perl guru.

@alyssais alyssais mentioned this pull request Jan 25, 2019
Closed
10 tasks
@Mic92 Mic92 mentioned this pull request Jan 26, 2019
Merged
10 tasks
@Ekleog
Copy link
Member

Ekleog commented Mar 8, 2019

This has now been merged once rebased, in #54616.

@Ekleog Ekleog closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyounkins @matthewbauer @peterhoeg @Ekleog @veprbl @GrahamcOfBorg