Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero: change desktop item name to Monero #51718

Merged
merged 1 commit into from Dec 8, 2018
Merged

monero: change desktop item name to Monero #51718

merged 1 commit into from Dec 8, 2018

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 8, 2018 •
edited

Motivation for this change

Rationale is to make it match application window title: https://github.com/monero-project/monero-gui/blob/0f05127262cf662ab549deae426c9deebf77967e/main.qml#L48

cc @rnhmjoj

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukateras lukateras changed the title monero: change desktop shortcut name to Monero monero: change desktop item name to Monero Dec 8, 2018
rnhmjoj
rnhmjoj approved these changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Thank you.

@lukateras lukateras merged commit 3ff3b83 into master Dec 8, 2018
@lukateras lukateras deleted the yegortimoshenko-patch-4 branch December 8, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @rnhmjoj @GrahamcOfBorg