Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: update php packages #51738

Merged
merged 18 commits into from Dec 11, 2018
Merged

php: update php packages #51738

merged 18 commits into from Dec 11, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 8, 2018 •
edited

Motivation for this change

Add package php v7.3.0
Changelog - http://www.php.net/ChangeLog-7.php#7.3.0
Update php to 7.1.25
Changelog - http://www.php.net/ChangeLog-7.php#7.1.25
Update php to 7.2.13
Changelog - http://www.php.net/ChangeLog-7.php#7.2.13

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin force-pushed the php73 branch 2 times, most recently from 445e235 to a0ecb60 Compare December 8, 2018 17:21
@Izorkin Izorkin requested a review from FRidh as a code owner December 8, 2018 17:21
@Izorkin Izorkin force-pushed the php73 branch 2 times, most recently from 17def9d to beb6300 Compare December 8, 2018 17:40
@Izorkin Izorkin changed the title php: init at 7.3.0 php: update php packages Dec 9, 2018
@etu
Copy link
Contributor

etu commented Dec 10, 2018

@GrahamcOfBorg build php71 php72 php73 php71-unit php72-unit php73-unit php71-embed php72-embed php73-embed

1 similar comment
@etu
Copy link
Contributor

etu commented Dec 10, 2018

@GrahamcOfBorg build php71 php72 php73 php71-unit php72-unit php73-unit php71-embed php72-embed php73-embed

@fpletz
Copy link
Member

fpletz commented Dec 11, 2018

Thanks a lot! 🍻 Did a rebase against current master to fix a small typo in a commit message. Checked building all php versions and ran the nextcloud and roundcube tests.

@fpletz
Copy link
Member

fpletz commented Dec 11, 2018

Tagged as security because 7.1 and 7.2 branch updates are security releases.

@fpletz fpletz merged commit 10d9fe7 into NixOS:master Dec 11, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 11, 2018

Thanks!

@Izorkin Izorkin deleted the php73 branch December 11, 2018 19:40
@fpletz
Copy link
Member

fpletz commented Dec 11, 2018

Backported the 7.1 and 7.2 updates to 18.09: 043a2be 6e0efb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @etu @fpletz @GrahamcOfBorg