Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport vivaldi updates from unstable #51711

Merged
merged 8 commits into from Dec 8, 2018
Merged

backport vivaldi updates from unstable #51711

merged 8 commits into from Dec 8, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Realized that we should probably backport Vivaldi updates to stable in #51646

cc @flokli @romildo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 8, 2018
@flokli flokli merged commit 7538184 into NixOS:release-18.09 Dec 8, 2018
@flokli
Copy link
Contributor

flokli commented Dec 8, 2018

Thanks!

@worldofpeace worldofpeace deleted the vivaldi/18.09-backport branch December 8, 2018 13:12
@worldofpeace worldofpeace mentioned this pull request Jan 3, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@worldofpeace @flokli @GrahamcOfBorg @lluchs @romildo @Synthetica9