mercurial: install zsh completions #51712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Dec 8, 2018
| @@ -50,7 +50,8 @@ in python2Packages.buildPythonApplication { | |||
| chmod u+x $out/share/cgi-bin/hgweb.cgi | |||
|
|
|||
| # install bash completion | |||
| install -D -v contrib/bash_completion $out/share/bash-completion/completions/mercurial | |||
| install -v -m644 -D contrib/bash_completion $out/share/bash-completion/completions/mercurial | |||
| install -v -m644 -D contrib/zsh_completion $out/share/zsh/site-functions/_hg | |||
There was a problem hiding this comment.
It is going to the nix store anyway, so, maybe, -m444?
hedning
reviewed
Dec 8, 2018
| @@ -50,7 +50,8 @@ in python2Packages.buildPythonApplication { | |||
| chmod u+x $out/share/cgi-bin/hgweb.cgi | |||
|
|
|||
| # install bash completion | |||
| install -D -v contrib/bash_completion $out/share/bash-completion/completions/mercurial | |||
| install -v -m644 -D contrib/bash_completion $out/share/bash-completion/completions/mercurial | |||
There was a problem hiding this comment.
Completion doesn't work in bash it seems, we need to copy to hg, _hg or hg.bash for bash-completion to lazy load the file. Should probably fix it while we're here :)
c0bw3b
reviewed
Dec 10, 2018
| @@ -50,7 +50,8 @@ in python2Packages.buildPythonApplication { | |||
| chmod u+x $out/share/cgi-bin/hgweb.cgi | |||
|
|
|||
| # install bash completion | |||
There was a problem hiding this comment.
And refresh that comment to install shell completions or install bash/zsh completions
|
Sorry for delay, updated as suggested!
Tested bash completion before/after, confirmed didn't work and now does
^_^.
…On Mon, 10 Dec 2018 13:50:28 -0800, Renaud ***@***.***> wrote:
c0bw3b commented on this pull request.
> @@ -50,7 +50,8 @@ in python2Packages.buildPythonApplication {
chmod u+x $out/share/cgi-bin/hgweb.cgi
# install bash completion
And refresh that comment to `install shell completions` or `install bash/zsh completions`
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#51712 (review) part: text/html
|
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
They're useful, you know :).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)