Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.binary-parsers : disable tests #51750

Merged
merged 1 commit into from Dec 12, 2018
Merged

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

The tests of the haskellPackages.binary-parser package break the build.

Things done

This patch disables the tests for binary-parsers package.

Note: There are two distinct packages: binary-parser and binary-parsers
The test suites of both packages seem to be broken.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Dec 11, 2018

@GrahamcOfBorg build

@srhb
Copy link
Contributor

srhb commented Dec 12, 2018

Possibly related to: winterland1989/binary-parsers#3

Built succesfully locally with sandbox.

@srhb srhb merged commit 27cd05e into NixOS:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants