Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certbot, acme: 0.24.0 -> 0.30.2 #51690

Merged
merged 4 commits into from Feb 11, 2019
Merged

certbot, acme: 0.24.0 -> 0.30.2 #51690

merged 4 commits into from Feb 11, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

(same source)

Motivation for this change

Have not reviewed changelogs or tested on a server.

Should at least make sure the 'acme' test passes :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 8, 2018

eep actually saw a build failure when trying it again, investigating...

@dtzWill dtzWill requested a review from FRidh as a code owner December 8, 2018 02:43
dotlambda
dotlambda reviewed Dec 9, 2018
View reviewed changes
pkgs/development/python-modules/acme/default.nix Outdated
];

checkInputs = [ nose ];
checkInputs = [ nose pytest ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nose is no longer needed.

dotlambda
dotlambda reviewed Jan 8, 2019
View reviewed changes
pkgs/tools/admin/certbot/default.nix Outdated
@@ -4,13 +4,13 @@

pythonPackages.buildPythonApplication rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, can we use python3Packages?

@dotlambda
Copy link
Member

@GrahamcOfBorg build nixosTests.acme

@dtzWill
certbot, acme: 0.24.0 -> 0.29.1
4be1d9a 
(same source)
@dtzWill
acme: add new deps on requests-toolbelt, pytest; fix
ea9853d
@dtzWill
acme: remove unneeded 'nose' dep, use 'sourceRoot' instead of postUnpack
44c84d1 
Specifying "source" in sourceRoot isn't ideal
(hopefully it doesn't change, again?)
but I think this is the preferred way to do this.
@dtzWill
acme, certbot: 0.29.1 -> 0.30.2
e79e038 
* move to python3
* touchup deps
@dtzWill dtzWill changed the title certbot, acme: 0.24.0 -> 0.29.1 certbot, acme: 0.24.0 -> 0.30.2 Feb 4, 2019
@domenkozar
Copy link
Member

@GrahamcOfBorg build nixosTests.acme

dotlambda
dotlambda approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it on my server, though.

@dtzWill dtzWill merged commit 4d8e3a2 into NixOS:master Feb 11, 2019
@dtzWill dtzWill deleted the update/acme-0.29.1 branch February 11, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @dotlambda @domenkozar @infinisil @GrahamcOfBorg