Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

efivar: 36 -> 37 #51701

Closed
wants to merge 2 commits into from
Closed

efivar: 36 -> 37 #51701

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change

https://github.com/rhboot/efivar/releases/tag/37

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 8, 2018

@GrahamcOfBorg build efibootmgr

c0bw3b
c0bw3b requested changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks efibootmgr

@dtzWill
efibootmgr: grab upstream commit as patch to fix w/efivar 37
1f99a9f 
(removes workaround for previous versions)
@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2018

Pushed fix using upstream commit, should work now-- let's let borg confirm? ^_^

@fpletz
Copy link
Member

fpletz commented Dec 17, 2018

Closing because #52322 has been merged. Pushed 1f99a9f to master.

@fpletz fpletz closed this Dec 17, 2018
@fpletz fpletz mentioned this pull request Dec 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @c0bw3b @fpletz @GrahamcOfBorg