Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups: 2.2.6 -> 2.2.10 #51699

Merged
merged 2 commits into from Dec 19, 2018
Merged

cups: 2.2.6 -> 2.2.10 #51699

merged 2 commits into from Dec 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the base branch from master to staging December 8, 2018 02:57
@dtzWill dtzWill changed the title ###### Motivation for this change cups: 2.2.6 -> 2.2.9 Dec 8, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 8, 2018

Still not sure why tooling ignores exit code? Anyway sorry about the noise :).

@rasendubi
Copy link
Member

rasendubi commented Dec 9, 2018 •
edited

2.2.10 is released: https://github.com/apple/cups/releases/tag/v2.2.10

@Mic92
Copy link
Member

Mic92 commented Dec 9, 2018

The errors for hub pull-requests, when editing a file are ignored here: https://github.com/github/hub/blob/f4252d55ecfa76aa4db50458faab4a269dada014/github/message_builder.go#L25

@dtzWill
Copy link
Member Author

dtzWill commented Dec 15, 2018

The errors for hub pull-requests, when editing a file are ignored here: https://github.com/github/hub/blob/f4252d55ecfa76aa4db50458faab4a269dada014/github/message_builder.go#L25

<3 thanks

Also, will be updating for new release shortly (just some commit shuffling/picking)

@dtzWill dtzWill changed the title cups: 2.2.6 -> 2.2.9 cups: 2.2.6 -> 2.2.10 Dec 16, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2018

Things like hplip have updates but that expression scares me :3.

@FRidh FRidh merged commit 61e9fc2 into NixOS:staging Dec 19, 2018
@dtzWill dtzWill mentioned this pull request Dec 20, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @rasendubi @Mic92 @FRidh @GrahamcOfBorg