Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mercurial: 4.8 -> 4.8.1 #51698

Closed
wants to merge 1 commit into from
Closed

mercurial: 4.8 -> 4.8.1 #51698

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change

https://www.mercurial-scm.org/wiki/WhatsNew#Mercurial_4.8.1_.282018-12-04.29

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Dec 8, 2018
View reviewed changes
pkgs/applications/version-management/mercurial/default.nix
@@ -4,7 +4,7 @@

let
# if you bump version, update pkgs.tortoisehg too or ping maintainer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this comment

@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

Looks like this was handled in the meantime with #52184 . Will note the comment in the future though, thanks.

@dtzWill dtzWill closed this Dec 29, 2018
@dtzWill dtzWill deleted the update/mercurial-4.8.1 branch December 29, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @GrahamcOfBorg