Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2c-tools: 4.0 -> 4.1 #51700

Merged
merged 2 commits into from Jan 5, 2019
Merged

i2c-tools: 4.0 -> 4.1 #51700

merged 2 commits into from Jan 5, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change

https://marc.info/?l=linux-i2c&m=154383448901807&w=2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested that they /run/ but don't have hardware to do anything interesting :).

@@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
'';

installPhase = ''
make install prefix=$out
make install PREFIX=$out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeFlags = [ "PREFIX=$(out)" ]; without overriding the install phase

@@ -17,7 +17,7 @@ stdenv.mkDerivation rec {
'';

installPhase = ''
make install prefix=$out
make install PREFIX=$out
rm -rf $out/include # Installs include/linux/i2c-dev.h that conflics with kernel headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this one step should rather be in a postInstall hook

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 8, 2018

Also patchPhase -> postPatch

@dtzWill dtzWill merged commit 2d79465 into NixOS:master Jan 5, 2019
@dtzWill dtzWill deleted the update/i2c-tools-4.1 branch January 5, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants