Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpop: 1.2.6 -> 1.4.1 #51692

Merged
merged 3 commits into from Dec 16, 2018
Merged

mpop: 1.2.6 -> 1.4.1 #51692

merged 3 commits into from Dec 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Update homepage and license.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
mpop: 1.2.6 -> 1.4.0
06b1017 
Update homepage and license.
c0bw3b
c0bw3b requested changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream strongly recommends to use GnuTLS only for TLS support. We should remove openssl here and keep only gnutls in build inputs and configure flags.

https://marlam.de/mpop/news/openssl-discouraged/
https://marlam.de/msmtp/news/openssl-discouraged/

The OpenSSL-related code in msmtp is essentially unmaintained. I don't work on it myself anymore, and the last time somebody sent a patch was 8 years ago. As a result, if you use msmtp with OpenSSL today, you don't get support for TLS SNI, --tls-priorities, --tls-crl-file, or --tls-min-dh-prime-bits.

SNI support is pretty much mandatory nowadays.

@dtzWill dtzWill changed the title mpop: 1.2.6 -> 1.4.0 mpop: 1.2.6 -> 1.4.1 Dec 16, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2018

Dropped openssl, bumped to 1.4.1 since new minor release :).

@c0bw3b c0bw3b merged commit c565746 into NixOS:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @c0bw3b @GrahamcOfBorg