s3: make scheme configurable #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Dec 7, 2018
|
Please also extend this list: https://github.com/NixOS/nix/blob/master/doc/manual/packages/s3-substituter.xml#L28 |
This enables using for http for S3 request for debugging or implementations that don't have https configured. This is not a problem for binary caches since they should not contain sensitive information. Both package signatures and AWS auth already protect against tampering.
grahamc
reviewed
Dec 7, 2018
| <para> | ||
| This enables using for http for S3 request for debugging or | ||
| implementations that don't have https configured. Should not | ||
| be used if the cache might contain sensitive information. |
There was a problem hiding this comment.
Let's put <example>https</example> (default) or <example>http</example> at the start, and then something like:
This option allows you to disable HTTPS for binary caches which don't support it. HTTPS should be used if the cache might contain sensitive information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using for http for S3 request for debugging or
implementations that don't have https configured. This is not a problem
for binary caches since they should not contain sensitive information.
Both package signatures and AWS auth already protect against tampering.