Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: fix cross compile (perl) #50926

Merged
merged 1 commit into from Nov 23, 2018
Merged

openssl: fix cross compile (perl) #50926

merged 1 commit into from Nov 23, 2018

Conversation

goertzenator
Copy link
Contributor

Fixes issue #50921. Build result was depending on build perl instead of
host perl which broke cross compilation.

Motivation for this change

Enable cross compilation of openssl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Nov 22, 2018

Please rebase this on the staging branch. That way the rebuilds introduced by this will have smaller priority and will not block other rebuilds.

@goertzenator
openssl: fix cross compile (perl)
1161746 
Fixes issue NixOS#50921. Build result was depending on build perl instead of
host perl which broke cross compilation.
@goertzenator goertzenator changed the base branch from master to staging November 22, 2018 21:12
@Mic92
Copy link
Member

Mic92 commented Nov 22, 2018 •
edited

@matthewbauer this seems like a good-enough solution to me until we can get fixing shebangs right. This way openssl does not block us too much when improving the support in other areas.

@matthewbauer
Copy link
Member

That sounds okay! I still need to figure out what is going on in the patch shebangs though. I thought it would be a no op on native builds so not sure what the error is.

@matthewbauer
Copy link
Member

If you could also reference the original issue so i can clean these up once we have an easier way to do this.

@FRidh FRidh merged commit e8bce19 into NixOS:staging Nov 23, 2018
@oxalica oxalica mentioned this pull request Mar 26, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@goertzenator @timokau @Mic92 @matthewbauer @FRidh @GrahamcOfBorg