Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uriparser: Enable cross-compilation #50937

Merged
merged 1 commit into from Nov 23, 2018
Merged

uriparser: Enable cross-compilation #50937

merged 1 commit into from Nov 23, 2018

Conversation

tathougies
Copy link
Contributor

Motivation for this change

uriparser needs some extra options to enable cross-compilation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 23, 2018

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.uriparser

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsCross.aarch64-multiplatform.uriparser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pkgsCross.aarch64-multiplatform.uriparser

Partial log (click to expand)

make[1]: Leaving directory '/build/uriparser-0.9.0/doc'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu
shrinking /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu/bin/uriparse
shrinking /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu/lib/liburiparser.so.1.0.23
aarch64-unknown-linux-gnu-strip is /nix/store/spkgb1j8yhnj1k6hqvqd4plbh7p39a1a-aarch64-unknown-linux-gnu-binutils-2.30/bin/aarch64-unknown-linux-gnu-strip
stripping (with command aarch64-unknown-linux-gnu-strip and flags -S) in /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu/lib  /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu/bin
patching script interpreter paths in /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu
checking for references to /build in /nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu...
/nix/store/rhg1ym1cmxxsvh0si102p8rvyp462bnw-uriparser-0.9.0-aarch64-unknown-linux-gnu

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgsCross.aarch64-multiplatform.uriparser

Partial log (click to expand)

make[1]: Leaving directory '/build/uriparser-0.9.0/doc'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0
shrinking /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0/bin/uriparse
shrinking /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0/lib/liburiparser.so.1.0.23
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0/lib  /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0/bin
patching script interpreter paths in /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0
checking for references to /build in /nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0...
/nix/store/3jzyr541jpjbsgys60gybjlvdbh3rab7-uriparser-0.9.0

@Mic92 Mic92 merged commit 8dca420 into NixOS:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tathougies @Mic92 @GrahamcOfBorg