Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-18.09] backport nss, libpng & sqlite updates #50963

Merged
merged 7 commits into from Dec 3, 2018
Merged

[staging-18.09] backport nss, libpng & sqlite updates #50963

merged 7 commits into from Dec 3, 2018

Conversation

andir
Copy link
Member

@andir andir commented Nov 23, 2018

This is the backport of the PRs #50374 & #46852.

Both of which will be required in a few weeks from now for the firefox bump.

As previously discussed with @vcunat in #50374 (comment) we should wait until those changes arrive in unstable/passed initial testing.

Feel free to merge whenever you feel the time is right. Preferably in time for the Firefox release ;)

/cc @dtzWill (since he dealt with the sqlite upgrade)
/cc @samueldr (the other release manager of 18.09)

@andir andir requested a review from vcunat November 23, 2018 18:41
@andir andir requested a review from FRidh as a code owner November 23, 2018 18:41
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

Generate a DSA key pair ...
Moving /nix/store/ry4qs1pqpsp7y0x2njv8yqfpmjqr3p36-nss-3.40/bin to /nix/store/gg5lig4kb5hk4hz3lbdqnvlwl2pfp3nb-nss-3.40-tools/bin
rmdir: failed to remove '/nix/store/ry4qs1pqpsp7y0x2njv8yqfpmjqr3p36-nss-3.40': Directory not empty
Moving /nix/store/gg5lig4kb5hk4hz3lbdqnvlwl2pfp3nb-nss-3.40-tools/bin/nss-config to /nix/store/k6a8bgnfgy67mwry99c7z57v2136z794-nss-3.40-dev/bin/nss-config
rmdir: failed to remove '/nix/store/gg5lig4kb5hk4hz3lbdqnvlwl2pfp3nb-nss-3.40-tools/bin': Directory not empty
Moving /nix/store/ry4qs1pqpsp7y0x2njv8yqfpmjqr3p36-nss-3.40/lib/libcrmf.a to /nix/store/k6a8bgnfgy67mwry99c7z57v2136z794-nss-3.40-dev/lib/libcrmf.a
rmdir: failed to remove '/nix/store/ry4qs1pqpsp7y0x2njv8yqfpmjqr3p36-nss-3.40/lib': Directory not empty
/nix/store/im2rf6hn8pdjqcbs2bf2r6vp8wvzc7qf-libpng-apng-1.6.35
/nix/store/ry4qs1pqpsp7y0x2njv8yqfpmjqr3p36-nss-3.40
/nix/store/dw50s3fy34jj4gvy19m536nh34yq5wi0-sqlite-3.25.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

Generate a DSA key pair ...
Moving /nix/store/7401k61y5h0xv2hjhbw558nlkv1fwa50-nss-3.40/bin to /nix/store/0fqypgh38jfcl0pmq7ijla71rxpw2ag8-nss-3.40-tools/bin
rmdir: failed to remove '/nix/store/7401k61y5h0xv2hjhbw558nlkv1fwa50-nss-3.40': Directory not empty
Moving /nix/store/0fqypgh38jfcl0pmq7ijla71rxpw2ag8-nss-3.40-tools/bin/nss-config to /nix/store/0acgqc346rdpfnl8fvlgm3ab5ag1wma6-nss-3.40-dev/bin/nss-config
rmdir: failed to remove '/nix/store/0fqypgh38jfcl0pmq7ijla71rxpw2ag8-nss-3.40-tools/bin': Directory not empty
Moving /nix/store/7401k61y5h0xv2hjhbw558nlkv1fwa50-nss-3.40/lib/libcrmf.a to /nix/store/0acgqc346rdpfnl8fvlgm3ab5ag1wma6-nss-3.40-dev/lib/libcrmf.a
rmdir: failed to remove '/nix/store/7401k61y5h0xv2hjhbw558nlkv1fwa50-nss-3.40/lib': Directory not empty
/nix/store/gra2xmsamdd21av2cvyh721zyynixrsd-libpng-apng-1.6.35
/nix/store/7401k61y5h0xv2hjhbw558nlkv1fwa50-nss-3.40
/nix/store/b5kxyjyabxjfrzha5h5kgxbrw5cavxq6-sqlite-3.25.3-bin

@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 23, 2018
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: libpng, nss, sqlite

Partial log (click to expand)

cannot build derivation '/nix/store/ng9rv5j2jllcy567mabjxclljjbmf6gy-apple-framework-NetFS.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vr3ilgd0fa7rz113n8hiy4yk062pf3bk-apple-framework-OpenDirectory.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0h7rfcl0cq7kj771bla0kigi1d56787a-apple-framework-CoreAudio.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/lky8iw5j3m8p0zi5nndxid8x33rd8zk2-apple-framework-DiskArbitration.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/b1vy8dvy7axj9mzdv4b28sdi8bj2r5x3-apple-framework-Security.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gnlzhr32a9qbil2y9gi32qk6p3ksivcm-apple-framework-ServiceManagement.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vhqva1kvhdi5ymyyq1jk850k5jn4a16z-apple-framework-CoreServices.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/i7hm9vak6ifwsjh6xdc30ad90k22qcri-nspr-4.19.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wnh9v7cjp5bx9j91z91my7rp83hb4x8i-nss-3.40.drv': 1 dependencies couldn't be built
error: build of '/nix/store/wnh9v7cjp5bx9j91z91my7rp83hb4x8i-nss-3.40.drv' failed

@samueldr
Copy link
Member

As previously discussed with @vcunat in #50374 (comment) we should wait until those changes arrive in unstable/passed initial testing.

Just so I'm clear, what should I look at, and where?

@andir
Copy link
Member Author

andir commented Nov 28, 2018

@samueldr the idea was (IIRC) to look out if something arises. The best place to actually see any comments/changes in that regard is probably the current staging-next PR that carries all these changes: #50876

vcunat referenced this pull request Nov 28, 2018
@7c6f434c
firefox: 63.0 -> 63.0.1; firefox-esr: 60.2.2esr -> 60.3.0esr
108de15
@vcunat vcunat merged commit aa3f523 into NixOS:staging-18.09 Dec 3, 2018
vcunat added a commit that referenced this pull request Dec 3, 2018
@vcunat
Merge #50963: nss, libpng & sqlite backports (staging-18.09)
4f5651d 
Planned date of FF 64 is in about a week.
@vcunat
Copy link
Member

vcunat commented Dec 3, 2018

Hmm, Firefox is a really heavy build nowadays: two versions of rustc, two versions of llvm, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andir @GrahamcOfBorg @samueldr @vcunat @c0bw3b @dtzWill