Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpscan: init at 3.4.0 #50958

Merged
merged 4 commits into from Nov 24, 2018
Merged

wpscan: init at 3.4.0 #50958

merged 4 commits into from Nov 24, 2018

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 23, 2018 •
edited

Motivation for this change

This is my first attempt to bundle a Ruby application, so any comment is welcome

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 23, 2018

@GrahamcOfBorg eval

@c0bw3b @nyanloutre
wpscan: fix typo in description
cdb0585 
Co-Authored-By: nyanloutre <paul@nyanlout.re>
worldofpeace
worldofpeace suggested changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/wpscanteam/wpscan#prerequisites the executable needs to be wrapped with curl.

Something like the snippet in #45435 should be sufficient.

worldofpeace and others added 2 commits November 24, 2018 11:11
@worldofpeace @nyanloutre
wpscan: missing indentation
ce64cca 
Co-Authored-By: nyanloutre <paul@nyanlout.re>
@nyanloutre
wpscan: wrap executable with curl
b2ad334
@nyanloutre
Copy link
Member Author

@worldofpeace I completed your request

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build wpscan

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wpscan

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: wpscan

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@worldofpeace
Copy link
Contributor

Oh yeah unfree.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2018 •
edited

ofBorg can't build unfree pkgs.

LGTM otherwise

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 24, 2018 •
edited

ofBorg can't build unfree pkgs.

I know, testing locally.

@c0bw3b c0bw3b merged commit 04c038e into NixOS:master Nov 24, 2018
@worldofpeace
Copy link
Contributor

Weird it fails with:
Unable to identify the wp-content dir, please supply it with --wp-content-dir

If I don't do that.

@nyanloutre nyanloutre deleted the wpscan branch November 24, 2018 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @c0bw3b @worldofpeace @GrahamcOfBorg