Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MailSender: init at 0.903 #50933

Merged
merged 1 commit into from Dec 6, 2018
Merged

perlPackages.MailSender: init at 0.903 #50933

merged 1 commit into from Dec 6, 2018

Conversation

cyounkins
Copy link
Contributor

Motivation for this change

Dependency of net-snmp tool checkbandwidth: https://sourceforge.net/p/net-snmp/code/ci/master/tree/local/checkbandwidth

Module is deprecated so this isn't great but I'm not sure what else to do.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyounkins cyounkins mentioned this pull request Nov 25, 2018
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

Module is deprecated so this isn't great but I'm not sure what else to do.

I honestly think writing a patch to use the recommended Email::Sender instead and submit it upstream is the better way. Check around other distros, maybe someone wrote it already?

@cyounkins
Copy link
Contributor Author

@c0bw3b I agree that patching upstream is better. However, in my efforts to improve nixpkgs I'd like to minimize 'yak shaving'. I ran into this as part of upgrading net-snmp per request #48099 and found the the checkbandwidth output didn't work. I'd like to commit this so I can work on #48099 and leave upstream or another user to fix the deprecation. I'm not a user of checkbandwidth or even net-snmp, I'm just trying to contribute back and learn about Nix.

Upstream bug: https://sourceforge.net/p/net-snmp/bugs/2905/

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 6, 2018

No problem. I did not mean to imply it should be your job to patch. Thanks for opening the upstream bug ticket.
Let's hope the original author of checkbandwidth (who wrote it in early 2018 when that Perl module was already deprecated BTW...) will revamp it a little.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 6, 2018

@GrahamcOfBorg build perl528Packages.MailSender

@c0bw3b c0bw3b merged commit a74c463 into NixOS:master Dec 6, 2018
@cyounkins cyounkins deleted the mail_sender branch December 6, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyounkins @c0bw3b @GrahamcOfBorg