Skip to content

direnv: make cross-compile on windows #50928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2018
Merged

direnv: make cross-compile on windows #50928

merged 1 commit into from
Nov 25, 2018
+10 −9

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 22, 2018 •
edited
Loading

Motivation for this change

show case of #50835 do not merge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Mic92 Mic92 added the 2.status: work-in-progress This PR isn't done label Nov 22, 2018
@Mic92 Mic92 changed the title direnv: 2.17.0 -> 2.18.1 + make cross-compile on windows [WIP] direnv: 2.17.0 -> 2.18.1 + make cross-compile on windows Nov 22, 2018
@Mic92 Mic92 mentioned this pull request Nov 22, 2018
Merged
14 tasks
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: direnv, go_1_11

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/q5lfnw5lzcb5l6qzgxfi69n3azk9x7g4-direnv-2.18.1-bin/bin
patching script interpreter paths in /nix/store/q5lfnw5lzcb5l6qzgxfi69n3azk9x7g4-direnv-2.18.1-bin
checking for references to /build/ in /nix/store/q5lfnw5lzcb5l6qzgxfi69n3azk9x7g4-direnv-2.18.1-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/0chyvxllsmw0jgzi7l184nmc9ypdv34y-direnv-2.18.1
strip is /nix/store/yyx28sl7a9n4xs9f82v0llpvrmryanan-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0chyvxllsmw0jgzi7l184nmc9ypdv34y-direnv-2.18.1
checking for references to /build/ in /nix/store/0chyvxllsmw0jgzi7l184nmc9ypdv34y-direnv-2.18.1...
/nix/store/q5lfnw5lzcb5l6qzgxfi69n3azk9x7g4-direnv-2.18.1-bin
/nix/store/plicr05pvfjwijnl8rzjx9p5h6ldb4ps-go-1.11.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: direnv, go_1_11

Partial log (click to expand)

cp -R man/*.1 /nix/store/qw76dl1dqg25529n1myk7aziapsvf1bl-direnv-2.18.1-bin/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/qw76dl1dqg25529n1myk7aziapsvf1bl-direnv-2.18.1-bin/share/man/
strip is /nix/store/4wic98ibvzb79nfrlq4gjpnys6d1ywl6-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qw76dl1dqg25529n1myk7aziapsvf1bl-direnv-2.18.1-bin/bin
patching script interpreter paths in /nix/store/qw76dl1dqg25529n1myk7aziapsvf1bl-direnv-2.18.1-bin
strip is /nix/store/4wic98ibvzb79nfrlq4gjpnys6d1ywl6-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/brd8j1bv3pixj2lgvf6pw8mxy5pwmc83-direnv-2.18.1
/nix/store/qw76dl1dqg25529n1myk7aziapsvf1bl-direnv-2.18.1-bin
/nix/store/9ay538168bq5yr5khnwillhxiwyir1rp-go-1.11.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: direnv, go_1_11

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/20smh811vqvjyi7mz4pg5d5y6hm447nj-direnv-2.18.1-bin/bin
patching script interpreter paths in /nix/store/20smh811vqvjyi7mz4pg5d5y6hm447nj-direnv-2.18.1-bin
checking for references to /build/ in /nix/store/20smh811vqvjyi7mz4pg5d5y6hm447nj-direnv-2.18.1-bin...
cannot find section .dynamic
shrinking RPATHs of ELF executables and libraries in /nix/store/c3c0lhw3zr636dna6g2jrf22ya6wsvbd-direnv-2.18.1
strip is /nix/store/br51frm28n8n85bs9wrcx6g8rpa42ain-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/c3c0lhw3zr636dna6g2jrf22ya6wsvbd-direnv-2.18.1
checking for references to /build/ in /nix/store/c3c0lhw3zr636dna6g2jrf22ya6wsvbd-direnv-2.18.1...
/nix/store/20smh811vqvjyi7mz4pg5d5y6hm447nj-direnv-2.18.1-bin
/nix/store/xkbjgmigkpzdmwv84y20cwpipvzlp5ih-go-1.11.2

@Mic92 Mic92 changed the title [WIP] direnv: 2.17.0 -> 2.18.1 + make cross-compile on windows direnv: make cross-compile on windows Nov 25, 2018
@Mic92 Mic92 merged commit b3ae7d1 into NixOS:staging Nov 25, 2018
@Mic92 Mic92 deleted the cross-go-windows branch November 25, 2018 00:13
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ labels Nov 25, 2018
@Mic92 Mic92 mentioned this pull request Mar 25, 2019
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @zimbatm