Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysdig: 0.23.1 -> 0.24.1 #50929

Merged
merged 1 commit into from Nov 23, 2018
Merged

sysdig: 0.23.1 -> 0.24.1 #50929

merged 1 commit into from Nov 23, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 22, 2018

Motivation for this change
  • support kernels 4.14.0 to 4.19.x

Minimum supported version defined in quirks.h
Compatibility with 4.19 introduced in draios/sysdig@4f433df and draios/sysdig@d32e5c5

  • move cmake and perl into native build inputs

  • licensing change:

    • userspace programs are now licensed under Apache 2.0
    • kernel module is now licensed under both MIT and GPLv2

See draios/sysdig@e404c50

/cc @7c6f434c @Mic92

I haven't tested booting with the module loaded, but it builds fine for 4.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
sysdig: 0.23.1 -> 0.24.1
c644bf3 
* support kernels 4.14.0 to 4.19.x

* move cmake and perl into native build inputs

* licensing change:
  - userspace programs are now licensed under Apache 2.0
  - kernel module is now licensed under both MIT and GPLv2
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sysdig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sysdig

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1
shrinking /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1/bin/sysdig
shrinking /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1/bin/csysdig
gzipping man pages under /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1/bin
patching script interpreter paths in /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1
/nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1/bin/sysdig-probe-loader: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1...
/nix/store/vwissdr9iq91b0sqpc5jljwb80y9nblp-sysdig-0.24.1

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 22, 2018

@GrahamcOfBorg build linuxPackages_latest.sysdig

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages_latest.sysdig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages_latest.sysdig

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1
shrinking /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/bin/csysdig
shrinking /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/bin/sysdig
gzipping man pages under /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/lib  /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/bin
patching script interpreter paths in /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1
/nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1/bin/sysdig-probe-loader: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1...
/nix/store/z90vq26wljcg9zq7dlyd7rakracxpa7r-sysdig-0.24.1

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 22, 2018

@GrahamcOfBorg build linuxPackages_4_14.sysdig

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: linuxPackages_4_14.sysdig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linuxPackages_4_14.sysdig

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1
shrinking /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/bin/sysdig
shrinking /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/bin/csysdig
gzipping man pages under /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/lib  /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/bin
patching script interpreter paths in /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1
/nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1/bin/sysdig-probe-loader: interpreter directive changed from "/bin/bash" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1...
/nix/store/ngvj09kivg4fzxzwhlj5fs9i6hpwfj8l-sysdig-0.24.1

@7c6f434c 7c6f434c merged commit 24b381e into NixOS:master Nov 23, 2018
@c0bw3b c0bw3b deleted the pkg/sysdig branch November 23, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @7c6f434c