Not sure why the python commits came up there...

I've updated up this pull request for a cleaner commit history and also fixed a typo. Could we re-review?

Actually I failed to get rid of the two extra commits in this pull request that aren't mine; not sure why they're there. Any suggestions?

@jbedo Can do git rebase -i HEAD~4 and remove foreign commits.

Hmm it just pushed the problem back to an earlier commit.

You can see in output of git log --pretty=fuller the offending commit has you as committer (somehow you re-committed it, probably during rebase). You should have been able to fix this with git rebase -i. The solution is still the same: GIT_SEQUENCE_EDITOR="sed -i -e 1d" git rebase -i HEAD~3 should do the trick right now.

Thanks!

Is there a reason why are you not using buildGoPackage? It contains all the trickery to correctly deal with go builds.

https://nixos.org/nixpkgs/manual/#sec-language-go

Singularity has it's own configuration and build process different from most go packages. A custom config script generates makefiles which eventually call go build and go run during the build. Their build process requires some patching to stop it trying to fetch dependencies itself, not use dependencies it ships with, and prevent the install process from installing SUID binaries. I initially started trying to use buildGoPackage but ended up using a standard builder because it mostly doesn't apply to the Singularity build process.

Your current derivation includes go compiler in the closure. It's not a huge deal, but buildGoPackage has a fix for that using removeReferencesTo:

Good point, I'll rewrite with the go builder.

It really didn't fit the go package builder as the install tree layout is not a standard gopkg install tree. I have instead removed references to go in the fixup stage.

@GrahamcOfBorg build singularity

@jbedo it is still a good idea to stick with buildGoPackage as this automatically makes cross-compiling works. Also see #52469 (comment) for further motivations.

Ok, however all three phases will be have to be overridden and multiple outputs disabled. It would be interesting to see if cross-compiling works, but since it only runs on x86_64-linux I'm not sure how much value this would be.

Updated to use buildGoPackage.

I just the following vm.nix in nixos-shell:

{ pkgs, ... }: {
  boot.kernelPackages = pkgs.linuxPackages_latest;
  services.openssh.enable = true;
  programs.singularity.enable = true;
}

but got the following error:

mv: cannot stat '/nix/store/wh092jwszihcsn9q8ysjri0ww3gxic70-singularity-3.0.1/libexec/singularity/bin/starter-suid': No such file or directory
builder for '/nix/store/aj5hjc0yzys9r3h7y03q1py4lfqgbiwi-singularity-3.0.1.drv' failed with exit code 1
error: build of '/nix/store/aj5hjc0yzys9r3h7y03q1py4lfqgbiwi-singularity-3.0.1.drv' on 'ssh://nix@eve.thalheim.io' failed: builder for '/nix/store/aj5hjc0yzys9r3h7y03q1py4lfqgbiwi-singularity
-3.0.1.drv' failed with exit code 1

Works! Thanks for your effort.

This has a merge conflict with master now.

@GrahamcOfBorg build singularity

The updated version works.

Minutes ago, I have just switched to unstable and try to use singularity, but it complains about UID error.

Then I struggled for a while and find that maybe this is caused by I turned on program.singularity and simultaneously put singularity in pkgs. Then the /run/current-system/sw/bin/singularity points to the latter one.

Finally I removed singularity in pkgs, and keep only program.singulariy enabled, then it works.

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/how-to-create-setuid-wrapper-for-installed-program/2590/6