Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite-web: init at 0.3.5 #50955

Merged
merged 1 commit into from Nov 26, 2018
Merged

sqlite-web: init at 0.3.5 #50955

merged 1 commit into from Nov 26, 2018

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Nov 23, 2018 •
edited by dotlambda

Motivation for this change

Request for new python package sqlite-web
closes #50949

Things done

pythonPackages.sqlite-web: init at 0.3.5

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner November 23, 2018 14:40
@costrouc
Copy link
Member Author

I am happy to be the maintainer of this package since it is pure python.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build python27Packages.sqlite-web python37Packages.sqlite-web

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.sqlite-web, python37Packages.sqlite-web

Partial log (click to expand)

/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/lib  /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5
checking for references to /build in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5...
wrapping `/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/zfpfsfzpbv3cl2yz0kfyafbgirzdhfk9-sqlite-web-0.3.5
/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.sqlite-web, python37Packages.sqlite-web

Partial log (click to expand)

/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/lib  /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
checking for references to /build in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5...
wrapping `/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/5xrqn0vxjvjwfpq1a6w9pvpbrajaz053-sqlite-web-0.3.5
/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5

@FRidh
Copy link
Member

FRidh commented Nov 23, 2018

This is an application and should therefore be called directly from all-packages.nix, and not via python-packages.nix.

@FRidh
Copy link
Member

FRidh commented Nov 23, 2018

Unless one is interested in the Python modules, then this is fine. But then buildPythonPackage needs to be used, and one might then have an entry in all-packages.nix as well.

@costrouc
Copy link
Member Author

This is exactly the question I was going to ask. In this case this package is an application and is not used as a python module nor do I see it ever being used as one. Fixed.

@costrouc costrouc changed the title pythonPackages.sqlite-web: init at 0.3.5 sqlite-web: init at 0.3.5 Nov 23, 2018
@costrouc
Copy link
Member Author

@GrahamcOfBorg build sqlite-web

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5

@FRidh
Copy link
Member

FRidh commented Nov 23, 2018

In that case the whole expression needs to be moved out of python-modules/python-packages.nix and elsewhere in Nixpkgs. Also, pass in python3Packages instead of the individual packages.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

Successfully installed sqlite-web-0.3.5
/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/lib  /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
checking for references to /build in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5...
wrapping `/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5

@costrouc
Copy link
Member Author

Fixed. Moved to development/tools/database/. This is the same directory that sqlitebrowser is in.

@costrouc
Copy link
Member Author

@GrahamcOfBorg build sqlite-web

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5

dotlambda
dotlambda requested changes Nov 23, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/database/sqlite-web/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/database/sqlite-web/default.nix Outdated Show resolved Hide resolved
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

Successfully installed sqlite-web-0.3.5
/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/lib  /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5
checking for references to /build in /nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5...
wrapping `/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/wwz3rxv8q5sfci6sj2xpd29bng7q1lm3-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

Successfully installed sqlite-web-0.3.5
/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/lib  /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5
checking for references to /build in /nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5...
wrapping `/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/l9s2kjxyfj0srn1d1fs684j0mkjikbhj-sqlite-web-0.3.5

@costrouc
Copy link
Member Author

@GrahamcOfBorg eval

@costrouc
Copy link
Member Author

Fixed. Ready for merge.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

Successfully installed sqlite-web-0.3.5
/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5/lib  /nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5
checking for references to /build in /nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5...
wrapping `/nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

  /nix/store/6jvkndb0jqsi7f290an3nvzr5kwzsdys-python3.7-Werkzeug-0.14.1.drv
  /nix/store/wrxa6p9c7ldkj6vgxzy0n2wyy16jnz54-openblas-0.3.3.drv
  /nix/store/myyqrf26yqd6pd13myl415c36jzdab8r-site.cfg.drv
  /nix/store/y62wlviklwd3zabbp1k6jah17lkfyasl-python3.7-numpy-1.15.3.drv
  /nix/store/9rvfslg11ryixz3m33654f9rpis6kjha-python3.7-Cython-0.29.drv
  /nix/store/nhbvj0hmh6h5ibglmhg5658xm5inyfyp-python3.7-Flask-1.0.2.drv
  /nix/store/izvvvi7n5kjmhsb98k8x21sh744xfl6j-python3.7-peewee-3.7.1.drv
  /nix/store/vhal6xicsarfbr69gdw7lfm8kkkbsgpd-sqlite-web-0.3.5.drv
waiting for locks or build slots...
/nix/store/zfr6jzz5md6q5gml3h94ichav4wsdss3-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)

Successfully installed sqlite-web-0.3.5
/build/sqlite-web-0.3.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5/lib  /nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5/bin
patching script interpreter paths in /nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5
checking for references to /build in /nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5...
wrapping `/nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5/bin/sqlite_web'...
/nix/store/rl9dpdxbxhzdfb8p5kzjm6rkq8c74jbk-sqlite-web-0.3.5

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sqlite-web

Partial log (click to expand)


#### 2018-11-26 04:41:07.729698

#### 2018-11-26 04:41:18.224781

#### 2018-11-26 04:41:28.247956
building of '/nix/store/z1c9pp31zajv3gfcpfcp41mazqff6p62-python3.7-Cython-0.29.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/yhq41ld4vmcdpfqq28w9hkvb86dvsnm1-python3.7-peewee-3.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h8f59vs5r48vn96pzllfm7vhmjmnl9g4-sqlite-web-0.3.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/h8f59vs5r48vn96pzllfm7vhmjmnl9g4-sqlite-web-0.3.5.drv' failed

@wmertens
Copy link
Contributor

Nice and concise!

LGTM

@dotlambda dotlambda merged commit aadeacf into NixOS:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sqlite-web
6 participants
@costrouc @GrahamcOfBorg @FRidh @c0bw3b @wmertens @dotlambda